This repository was archived by the owner on May 16, 2025. It is now read-only.
Fix memory leak (metafacture-core#666) #391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let maps implement Closeable. Bump metafacture-core version. Follow .github/workflows/build.yml to build the proper metafacture-core dependency.
|
Closed intentionally. This branch is needed because we cannot make a release because we cannot release the needed metafacture-core 5.7.1 version atm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE THIS PR!
Fixes a memory leak for old programs running java 8.
This is a branch which fixes a memory leak (see (metafacture-core#666)). It's build on the latest release which uses java 8.
Resolves metafacture/metafacture-core#666 (comment).
Use like:
look at the needed metafacture-core 5.7.1 dependency build as noted in https://github.com/metafacture/metafacture-fix/blob/publish-0.7.1-fixMemoryLeak/.github/workflows/build.yml. Then:
git checkout 0.7.1; /gradlew publishToMavenLocal. You can then consume the locally buildmetafix/0.7.1