Skip to content

proposal; drop SVG arrow calculation #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

proposal; drop SVG arrow calculation #1278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions js/prev-next-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,8 @@ PrevNextButton.prototype.createSVG = function( label, arrowShape ) {
function getArrowMovements( shape ) {
// use shape as movement if string
if ( typeof shape == 'string' ) return shape;

let { x0, x1, x2, x3, y1, y2 } = shape;

// create movement string
return `M ${x0}, 50
L ${x1}, ${y1 + 50}
L ${x2}, ${y2 + 50}
L ${x3}, 50
L ${x2}, ${50 - y2}
L ${x1}, ${50 - y1}
Z`;
// return fallback `arrow left`
return `m10 50 50 50 10-10-40-40 40-40-10-10Z`;
}

// ----- ----- //
Expand Down