Skip to content

fix split install error #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix split install error #3040

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3436f73
fix split install error
DaVinci9196 Aug 28, 2025
5016fad
Merge branch 'master' into fix_split_install_error
mar-v-in Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions vending-app/src/main/kotlin/com/android/vending/installer/Install.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ private suspend fun Context.installPackagesInternal(
} catch (e: Exception) {
Log.w(TAG, "Error setting dontKillApp", e)
}
val sessionId: Int
var sessionId: Int
var session: PackageInstaller.Session? = null
try {
val sessionInfo = packageInstaller.mySessions.firstOrNull{ it.appLabel == key }
Expand All @@ -147,7 +147,7 @@ private suspend fun Context.installPackagesInternal(

for (component in componentNames) {
val currentSize: Long = try {
val inputStream = session.openRead(component)
val inputStream = session!!.openRead(component)
val totalSize = withContext(Dispatchers.IO) {
val buffer = ByteArray(4096)
var total = 0L
Expand All @@ -162,10 +162,17 @@ private suspend fun Context.installPackagesInternal(
} catch (e: IOException) {
Log.w(TAG, "installPackagesInternal session open read error, ${e.message}")
0L
} catch (e: SecurityException) {
Log.w(TAG, "installPackagesInternal session open read error, ${e.message}")
//Handling exceptions java.lang.SecurityException: openRead not allowed after commit
session!!.abandon()
sessionId = packageInstaller.createSession(params)
session = packageInstaller.openSession(sessionId)
0L
}

Log.d(TAG, "installPackagesInternal component: $component currentSize:$currentSize")
session.openWrite(component, currentSize, -1).use { outputStream ->
session!!.openWrite(component, currentSize, -1).use { outputStream ->
try {
writeComponent(currentSize, notifyId, component, outputStream)
session.fsync(outputStream)
Expand Down Expand Up @@ -197,7 +204,7 @@ private suspend fun Context.installPackagesInternal(
)!!

emitProgress(notifyId, CommitingSession)
session.commit(pendingIntent.intentSender)
session!!.commit(pendingIntent.intentSender)
// don't abandon if `finally` step is reached after this point
//session.close()

Expand Down