Skip to content

D3D12RaytracingRealTimeDenoisedAmbientOcclusion - large per frame upload #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

D3D12RaytracingRealTimeDenoisedAmbientOcclusion - large per frame upload #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
964d882
Fixed FXC validation error: uav store write mask must match store val…
mackrol Dec 19, 2020
c50a1b8
Hemisphere samples array is uploaded only on recreation of AO samples…
mackrol Dec 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...Desktop/D3D12Raytracing/src/D3D12RaytracingRealTimeDenoisedAmbientOcclusion/RTAO/RTAO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ void RTAO::CreateSamplesRNG()
m_samplesGPUBuffer[i].value = XMFLOAT2(p.x * 0.5f + 0.5f, p.y * 0.5f + 0.5f);
m_hemisphereSamplesGPUBuffer[i].value = p;
}
m_numAOSamplesUploadFrames = m_deviceResources->GetBackBufferCount();
}

void RTAO::GetRayGenParameters(bool* isCheckerboardSamplingEnabled, bool* checkerboardLoadEvenPixels)
Expand Down Expand Up @@ -547,8 +548,11 @@ void RTAO::Run(
}

// Copy dynamic buffers to GPU.
UpdateConstantBuffer(frameIndex);

if (m_numAOSamplesUploadFrames)
{
UpdateConstantBuffer(frameIndex);
m_numAOSamplesUploadFrames--;
m_hemisphereSamplesGPUBuffer.CopyStagingToGpu(frameIndex);
}

Expand Down
1 change: 1 addition & 0 deletions ...s/Desktop/D3D12Raytracing/src/D3D12RaytracingRealTimeDenoisedAmbientOcclusion/RTAO/RTAO.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class RTAO
StructuredBuffer<AlignedHemisphereSample3D> m_hemisphereSamplesGPUBuffer;
BOOL m_isRecreateAOSamplesRequested = true;

UINT m_numAOSamplesUploadFrames = 0;
UINT m_numAORayGeometryHits;
bool m_checkerboardGenerateRaysForEvenPixels = false;

Expand Down
3 changes: 3 additions & 0 deletions ...racingRealTimeDenoisedAmbientOcclusion/SampleCore/Shaders/util/GenerateGrassStrawsCS.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ void main(uint2 DTid : SV_DispatchThreadID)
{
VertexPositionNormalTextureTangent vertex;
vertex.position = 0;
vertex.normal = 0;
vertex.textureCoordinate = 0;
vertex.tangent = 0;
uint threadID = DTid.x + DTid.y * cb.p.maxPatchDim.x;
uint baseVertexID = threadID * N_GRASS_VERTICES;

Expand Down