Skip to content

Fix Typo in PTRBITCAST #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix Typo in PTRBITCAST #7438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/DXIL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3174,7 +3174,7 @@ INSTR.OPCONST DXIL intrinsic requires an
INSTR.OPCONSTRANGE Constant values must be in-range for operation.
INSTR.OPERANDRANGE DXIL intrinsic operand must be within defined range
INSTR.PARAMMULTIPLE Parameter must be a valid multiple
INSTR.PTRBITCAST Pointer type bitcast must be have same size.
INSTR.PTRBITCAST Pointer type bitcast must have same size.
INSTR.RESOURCECLASSFORLOAD load can only run on UAV/SRV resource.
INSTR.RESOURCECLASSFORSAMPLERGATHER sample, lod and gather should be on srv resource.
INSTR.RESOURCECLASSFORUAVSTORE store should be on uav resource.
Expand Down
2 changes: 1 addition & 1 deletion tools/clang/unittests/HLSL/ValidationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,7 +1724,7 @@ TEST_F(ValidationTest, PtrBitCast) {
"%\\1 = getelementptr [4 x i32], [4 x i32]* %\\2, i32 0, i32 0\n"
" %X = bitcast i32* %\\1 to double* \n"
" store i32 %\\3, i32* %\\1, align 4",
"Pointer type bitcast must be have same size",
"Pointer type bitcast must have same size",
/*bRegex*/ true);
}

Expand Down
2 changes: 1 addition & 1 deletion utils/hct/hctdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8068,7 +8068,7 @@ def build_valrules(self):
"Call to DXIL intrinsic '%0' does not match an allowed overload signature.",
)
self.add_valrule(
"Instr.PtrBitCast", "Pointer type bitcast must be have same size."
"Instr.PtrBitCast", "Pointer type bitcast must have same size."
)
self.add_valrule(
"Instr.MinPrecisonBitCast", "Bitcast on minprecison types is not allowed."
Expand Down