[SPIR-V] Disable validation for a broken test #7682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is a 120mn timeout which happens sometimes. |
The code emitted with this test would not pass validation rules for 06677 as the empty cbuffers generate a UniformConstant variable with no binding decoration. Seems like an oversight from DXC which would be OK if it only happened with `-fcgl` but since this also happens in `-O0` this is a bug. Related to microsoft#7681
Keenuts
force-pushed
the
disable-validation
branch
from
6f74af7 to
93f517f
Compare
s-perron
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code emitted with this test would not pass validation rules for 06677 as the empty cbuffers generate a UniformConstant variable with no binding decoration.
Seems like an oversight from DXC which would be OK if it only happened with
-fcglbut since this also happens in-O0this is a bug.Related to #7681