Skip to content

Conversation

@alsepkow
Copy link
Contributor

TAEF deprecated the miniDumpOnCrashOption. Remove it as it's only adding noise to test logs now.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r ac26e531f6ade701cf565f6e284850b16d85474b..af3be23751d20fae93c3956789b137ae98cd3c35 utils/lit/lit/formats/taef.py
View the diff from darker here.
--- taef.py	2025-10-15 00:02:33.000000 +0000
+++ taef.py	2025-10-20 23:33:35.639229 +0000
@@ -123,14 +123,19 @@
         select_filter = str.format("@Name='{}'", testName)
 
         if self.select_filter != "":
             select_filter = str.format("{} AND {}", select_filter, self.select_filter)
 
-        cmd = [self.te, test_dll, '/inproc',
-                '/select:', select_filter,
-                '/unicodeOutput:false',
-                str.format('/outputFolder:{}', self.test_path)]
+        cmd = [
+            self.te,
+            test_dll,
+            "/inproc",
+            "/select:",
+            select_filter,
+            "/unicodeOutput:false",
+            str.format("/outputFolder:{}", self.test_path),
+        ]
         cmd.extend(self.extra_params)
 
         if litConfig.useValgrind:
             cmd = litConfig.valgrindArgs + cmd
 
  • Check this box to apply formatting changes to this branch.

@alsepkow alsepkow enabled auto-merge (squash) October 18, 2025 00:46
@alsepkow alsepkow merged commit 77c2579 into microsoft:main Oct 21, 2025
14 of 18 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants