-
Notifications
You must be signed in to change notification settings - Fork 805
Fix nuget config override option, set default warp version to 1.0.15 #7825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix nuget config override option, set default warp version to 1.0.15 #7825
Conversation
…option warp-nuget-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming build succeeds.
It'd be nice if the default was set in DownloadWarp.cmake so that the knowledge about which version of warp to use wasn't baked in to azure-pipelines.yml, but we can always make that change later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it looks like the new good version is 1.0.16.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for what it's doing here, but I'd prefer to see the LKG hard coded in hctbuild.cmd or DownloadWarp.cmake so we don't have to put it into every pipeline yml file.
Happy to leave changing that for another day.
Jesse mentioned he published the last Warp version specifically for the purpose of getting bug reports from users. So there is some advantage in leaving hctbuild / DownloadWarp.cmake to download the latest warp, so that devs can file reports. Devs can override the warp version if they need to be unblocked too. |
This PR fixes the current failures in the PR pipelines by defaulting the nuget warp install version to 1.0.15 for the pipelins. Devs will still pull the latest warp version.
It also fixes the override option that wasn't quite working before, so that the desired nuget warp version can be overridden.
When invoking hctbuild, just pass -nuget-config "-Version " to install a specific version of warp.