Skip to content

<regex>: Fix regex_error when matching a repeated pattern containing a lookahead assertion #5793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

<regex>: Fix regex_error when matching a repeated pattern containing a lookahead assertion #5793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a6fb6
`<regex>`: Fix `regex_error` when matching a repeated pattern contain…
muellerj2 Oct 20, 2025
5a50ab2
Merge branch 'main' into regex-fix-assertion-inside-repeated-pattern
StephanTLavavej Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stl/inc/regex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3521,7 +3521,7 @@ bool _Matcher3<_BidIt, _Elem, _RxTraits, _It, _Alloc>::_Find_first_inner_capture

case _N_assert:
case _N_neg_assert:
if (_Find_first_inner_capture_group(static_cast<_Node_assert*>(_Nx), _Loop_state)) {
if (_Find_first_inner_capture_group(static_cast<_Node_assert*>(_Nx)->_Child, _Loop_state)) {
_Found_group = true;
_Nx = nullptr;
}
Expand Down
10 changes: 10 additions & 0 deletions tests/std/tests/VSO_0000000_regex_use/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2223,6 +2223,15 @@ void test_gh_5790() {
}
}

void test_gh_5792() {
// GH-5792: <regex>: regex_match() throws regex_error(error_stack)
// when a repeated pattern contains a lookahead assertion
g_regexTester.should_match("", "(?:(?=ab))*");
g_regexTester.should_match("", "(?:(?!ab))*");
g_regexTester.should_not_match("bc", "(?:(?=ab))+bc");
g_regexTester.should_match("bc", "(?:(?!ab))+bc");
}

int main() {
test_dev10_449367_case_insensitivity_should_work();
test_dev11_462743_regex_collate_should_not_disable_regex_icase();
Expand Down Expand Up @@ -2276,6 +2285,7 @@ int main() {
test_gh_5672();
test_gh_5774();
test_gh_5790();
test_gh_5792();

return g_regexTester.result();
}