Improve URLSearchParams constructor type definition

[rossrobino]

Overrides the type of URLSearchParams init to accept a Iterable<[string, string]> instead of string[][].

MDN Reference

For example:

new URLSearchParams(new Set([["name", "ross"]]));

is valid, but currently shows an error.

There was an added type of URLSearchParams which I figured I should remove, the Iterable<[string, string]> type covers this case as well.

[rossrobino]

@microsoft-github-policy-service agree

[github-actions]

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

[jakebailey]

I can't seem to get it to generate, I'm getting a ENOENT error. I don't have files in /inputfiles/mdn/

You need to have cloned the submodule as well.

git submodule update --init

[saschanaz]

This is blocked by #222 because vars can't be split by separate type declarations. We cannot just override the constructor because it'll break ES5 compatibility.

microsoft/TypeScript#3538 could greatly help without all those separate libs but I don't see that coming anytime soon.

[jakebailey]

ES5 is going to be deprecated, so maybe there's a future where it'd work out.

[rossrobino]

Thanks @jakebailey, got it to generate and committed the changes.

I am seeing the Cannot find name 'Iterable' error now during the test run, I assume this is the ES5 issue. Let me know if not!

[jakebailey]

Correct, but we're likely making DOM imply ES6 and DOM.Iterable in 6.0

[saschanaz]

But will 6.0 remove ES5 completely?