Skip to content

Add __brand to make empty interfaces nominal #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions baselines/audioworklet.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1586,6 +1586,7 @@ declare namespace WebAssembly {

/** [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Module) */
interface Module {
__brand: "Module";
}

var Module: {
Expand Down
17 changes: 17 additions & 0 deletions baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7468,6 +7468,7 @@ declare var CSSStyleSheet: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleValue)
*/
interface CSSStyleValue {
__brand: "CSSStyleValue";
toString(): string;
}

Expand Down Expand Up @@ -20772,6 +20773,7 @@ declare var MediaSource: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/MediaSourceHandle)
*/
interface MediaSourceHandle {
__brand: "MediaSourceHandle";
}

declare var MediaSourceHandle: {
Expand Down Expand Up @@ -24119,6 +24121,7 @@ declare var PerformanceTiming: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/PeriodicWave)
*/
interface PeriodicWave {
__brand: "PeriodicWave";
}

declare var PeriodicWave: {
Expand Down Expand Up @@ -25613,6 +25616,7 @@ declare var RTCRtpReceiver: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCRtpScriptTransform)
*/
interface RTCRtpScriptTransform {
__brand: "RTCRtpScriptTransform";
}

declare var RTCRtpScriptTransform: {
Expand Down Expand Up @@ -35350,6 +35354,7 @@ declare var WebGLActiveInfo: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLBuffer)
*/
interface WebGLBuffer {
__brand: "WebGLBuffer";
}

declare var WebGLBuffer: {
Expand Down Expand Up @@ -35382,6 +35387,7 @@ declare var WebGLContextEvent: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLFramebuffer)
*/
interface WebGLFramebuffer {
__brand: "WebGLFramebuffer";
}

declare var WebGLFramebuffer: {
Expand All @@ -35395,6 +35401,7 @@ declare var WebGLFramebuffer: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLProgram)
*/
interface WebGLProgram {
__brand: "WebGLProgram";
}

declare var WebGLProgram: {
Expand All @@ -35408,6 +35415,7 @@ declare var WebGLProgram: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLQuery)
*/
interface WebGLQuery {
__brand: "WebGLQuery";
}

declare var WebGLQuery: {
Expand All @@ -35421,6 +35429,7 @@ declare var WebGLQuery: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLRenderbuffer)
*/
interface WebGLRenderbuffer {
__brand: "WebGLRenderbuffer";
}

declare var WebGLRenderbuffer: {
Expand Down Expand Up @@ -36366,6 +36375,7 @@ interface WebGLRenderingContextOverloads {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLSampler)
*/
interface WebGLSampler {
__brand: "WebGLSampler";
}

declare var WebGLSampler: {
Expand All @@ -36379,6 +36389,7 @@ declare var WebGLSampler: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLShader)
*/
interface WebGLShader {
__brand: "WebGLShader";
}

declare var WebGLShader: {
Expand Down Expand Up @@ -36423,6 +36434,7 @@ declare var WebGLShaderPrecisionFormat: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLSync)
*/
interface WebGLSync {
__brand: "WebGLSync";
}

declare var WebGLSync: {
Expand All @@ -36436,6 +36448,7 @@ declare var WebGLSync: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLTexture)
*/
interface WebGLTexture {
__brand: "WebGLTexture";
}

declare var WebGLTexture: {
Expand All @@ -36449,6 +36462,7 @@ declare var WebGLTexture: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLTransformFeedback)
*/
interface WebGLTransformFeedback {
__brand: "WebGLTransformFeedback";
}

declare var WebGLTransformFeedback: {
Expand All @@ -36462,6 +36476,7 @@ declare var WebGLTransformFeedback: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLUniformLocation)
*/
interface WebGLUniformLocation {
__brand: "WebGLUniformLocation";
}

declare var WebGLUniformLocation: {
Expand All @@ -36475,6 +36490,7 @@ declare var WebGLUniformLocation: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLVertexArrayObject)
*/
interface WebGLVertexArrayObject {
__brand: "WebGLVertexArrayObject";
}

declare var WebGLVertexArrayObject: {
Expand Down Expand Up @@ -38168,6 +38184,7 @@ declare namespace WebAssembly {

/** [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Module) */
interface Module {
__brand: "Module";
}

var Module: {
Expand Down
14 changes: 14 additions & 0 deletions baselines/serviceworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1555,6 +1555,7 @@ declare var CSSSkewY: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleValue)
*/
interface CSSStyleValue {
__brand: "CSSStyleValue";
toString(): string;
}

Expand Down Expand Up @@ -9157,6 +9158,7 @@ declare var WebGLActiveInfo: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLBuffer)
*/
interface WebGLBuffer {
__brand: "WebGLBuffer";
}

declare var WebGLBuffer: {
Expand Down Expand Up @@ -9189,6 +9191,7 @@ declare var WebGLContextEvent: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLFramebuffer)
*/
interface WebGLFramebuffer {
__brand: "WebGLFramebuffer";
}

declare var WebGLFramebuffer: {
Expand All @@ -9202,6 +9205,7 @@ declare var WebGLFramebuffer: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLProgram)
*/
interface WebGLProgram {
__brand: "WebGLProgram";
}

declare var WebGLProgram: {
Expand All @@ -9215,6 +9219,7 @@ declare var WebGLProgram: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLQuery)
*/
interface WebGLQuery {
__brand: "WebGLQuery";
}

declare var WebGLQuery: {
Expand All @@ -9228,6 +9233,7 @@ declare var WebGLQuery: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLRenderbuffer)
*/
interface WebGLRenderbuffer {
__brand: "WebGLRenderbuffer";
}

declare var WebGLRenderbuffer: {
Expand Down Expand Up @@ -10171,6 +10177,7 @@ interface WebGLRenderingContextOverloads {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLSampler)
*/
interface WebGLSampler {
__brand: "WebGLSampler";
}

declare var WebGLSampler: {
Expand All @@ -10184,6 +10191,7 @@ declare var WebGLSampler: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLShader)
*/
interface WebGLShader {
__brand: "WebGLShader";
}

declare var WebGLShader: {
Expand Down Expand Up @@ -10228,6 +10236,7 @@ declare var WebGLShaderPrecisionFormat: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLSync)
*/
interface WebGLSync {
__brand: "WebGLSync";
}

declare var WebGLSync: {
Expand All @@ -10241,6 +10250,7 @@ declare var WebGLSync: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLTexture)
*/
interface WebGLTexture {
__brand: "WebGLTexture";
}

declare var WebGLTexture: {
Expand All @@ -10254,6 +10264,7 @@ declare var WebGLTexture: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLTransformFeedback)
*/
interface WebGLTransformFeedback {
__brand: "WebGLTransformFeedback";
}

declare var WebGLTransformFeedback: {
Expand All @@ -10267,6 +10278,7 @@ declare var WebGLTransformFeedback: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLUniformLocation)
*/
interface WebGLUniformLocation {
__brand: "WebGLUniformLocation";
}

declare var WebGLUniformLocation: {
Expand All @@ -10280,6 +10292,7 @@ declare var WebGLUniformLocation: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLVertexArrayObject)
*/
interface WebGLVertexArrayObject {
__brand: "WebGLVertexArrayObject";
}

declare var WebGLVertexArrayObject: {
Expand Down Expand Up @@ -10961,6 +10974,7 @@ declare namespace WebAssembly {

/** [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Module) */
interface Module {
__brand: "Module";
}

var Module: {
Expand Down
14 changes: 14 additions & 0 deletions baselines/sharedworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1491,6 +1491,7 @@ declare var CSSSkewY: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleValue)
*/
interface CSSStyleValue {
__brand: "CSSStyleValue";
toString(): string;
}

Expand Down Expand Up @@ -8700,6 +8701,7 @@ declare var WebGLActiveInfo: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLBuffer)
*/
interface WebGLBuffer {
__brand: "WebGLBuffer";
}

declare var WebGLBuffer: {
Expand Down Expand Up @@ -8732,6 +8734,7 @@ declare var WebGLContextEvent: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLFramebuffer)
*/
interface WebGLFramebuffer {
__brand: "WebGLFramebuffer";
}

declare var WebGLFramebuffer: {
Expand All @@ -8745,6 +8748,7 @@ declare var WebGLFramebuffer: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLProgram)
*/
interface WebGLProgram {
__brand: "WebGLProgram";
}

declare var WebGLProgram: {
Expand All @@ -8758,6 +8762,7 @@ declare var WebGLProgram: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLQuery)
*/
interface WebGLQuery {
__brand: "WebGLQuery";
}

declare var WebGLQuery: {
Expand All @@ -8771,6 +8776,7 @@ declare var WebGLQuery: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLRenderbuffer)
*/
interface WebGLRenderbuffer {
__brand: "WebGLRenderbuffer";
}

declare var WebGLRenderbuffer: {
Expand Down Expand Up @@ -9714,6 +9720,7 @@ interface WebGLRenderingContextOverloads {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLSampler)
*/
interface WebGLSampler {
__brand: "WebGLSampler";
}

declare var WebGLSampler: {
Expand All @@ -9727,6 +9734,7 @@ declare var WebGLSampler: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLShader)
*/
interface WebGLShader {
__brand: "WebGLShader";
}

declare var WebGLShader: {
Expand Down Expand Up @@ -9771,6 +9779,7 @@ declare var WebGLShaderPrecisionFormat: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLSync)
*/
interface WebGLSync {
__brand: "WebGLSync";
}

declare var WebGLSync: {
Expand All @@ -9784,6 +9793,7 @@ declare var WebGLSync: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLTexture)
*/
interface WebGLTexture {
__brand: "WebGLTexture";
}

declare var WebGLTexture: {
Expand All @@ -9797,6 +9807,7 @@ declare var WebGLTexture: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLTransformFeedback)
*/
interface WebGLTransformFeedback {
__brand: "WebGLTransformFeedback";
}

declare var WebGLTransformFeedback: {
Expand All @@ -9810,6 +9821,7 @@ declare var WebGLTransformFeedback: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLUniformLocation)
*/
interface WebGLUniformLocation {
__brand: "WebGLUniformLocation";
}

declare var WebGLUniformLocation: {
Expand All @@ -9823,6 +9835,7 @@ declare var WebGLUniformLocation: {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/WebGLVertexArrayObject)
*/
interface WebGLVertexArrayObject {
__brand: "WebGLVertexArrayObject";
}

declare var WebGLVertexArrayObject: {
Expand Down Expand Up @@ -10687,6 +10700,7 @@ declare namespace WebAssembly {

/** [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Module) */
interface Module {
__brand: "Module";
}

var Module: {
Expand Down
1 change: 1 addition & 0 deletions baselines/ts5.5/audioworklet.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1586,6 +1586,7 @@ declare namespace WebAssembly {

/** [MDN Reference](https://developer.mozilla.org/docs/WebAssembly/Reference/JavaScript_interface/Module) */
interface Module {
__brand: "Module";
}

var Module: {
Expand Down
Loading