Skip to content

Add links to comments #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add links to comments #2086

wants to merge 2 commits into from

Conversation

Bashamega
Copy link
Contributor

Originally suggested by me in #2078 (comment)

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@@ -889,7 +889,7 @@ declare var ReadableByteStreamController: {
};

/**
* The `ReadableStream` interface of the Streams API represents a readable stream of byte data.
* The `ReadableStream` interface of the [Streams API](/en-US/docs/Web/API/Streams_API) represents a readable stream of byte data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is unrooted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it @jakebailey

@jakebailey
Copy link
Member

Is this actually a good idea? It seems like a lot of text, and the docs already include a link.

@Bashamega
Copy link
Contributor Author

Is this actually a good idea? It seems like a lot of text, and the docs already include a link.

I think people would benefit from it, maybe @saschanaz has an opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants