Skip to content

Don't use noErrorTruncation when printing types with maximumLength set #62091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Don't use noErrorTruncation when printing types with maximumLength set #62091

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfe14f0
Don't use `noErrorTruncation` when printing types with `maximumLength…
Andarist Jul 19, 2025
a8918e6
actually add `noErrorTruncation: true` to the test, oops
Andarist Jul 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6156,7 +6156,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
verbosityLevel?: number,
out?: WriterContextOut,
): string {
const noTruncation = compilerOptions.noErrorTruncation ||
const noTruncation = !maximumLength && compilerOptions.noErrorTruncation ||
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, compilerOptions.noErrorTruncation could increase the maximumLength to its usual limit - but I think this small solution is a better way out of this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this, the another user who reported the problem here gets:
image

and they agree it's an improvement but they still can't expand this type in VS Code - when they can expand other types

flags & TypeFormatFlags.NoTruncation;
const typeNode = nodeBuilder.typeToTypeNode(
type,
Expand Down
Loading
Loading