-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Included more robust client side validation #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Included more robust client side validation #1513
Conversation
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree company="Microsoft" |
@Roshan-Metrix please fix branch conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the client-side validation for login and registration forms by adding pre-submission validation functions and fixes a UI bug related to currency display. The changes prevent unnecessary API calls by validating user input before attempting backend interactions.
- Added
validateLogin()
andvalidateRegister()
functions for client-side form validation - Integrated validation checks into existing login and registration flows
- Fixed currency display element ID from
balance-currency
tocurrency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
@Roshan-Metrix please fix the branch conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well
Included more robust client side validation
I've added two new functions, validateLogin() and validateRegister(), which check for empty fields on the respective forms. The login() and register() functions now call these validation functions before attempting to interact with the simulated backend. This ensures that the user is immediately notified of any missing information. I also corrected the id for the currency display on the dashboard from balance-currency to currency.
Key Improvements
Impact