Skip to content

Conversation

@AndrewKeepCoding
Copy link
Contributor

Description

This PR updates the SplitView sample to switch layouts dynamically depending on the pane's placement (left or right).

Motivation and Context

Fixes #322.

How Has This Been Tested?

Manually tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AndrewKeepCoding
Copy link
Contributor Author

@marcelwgn Do you think we should horizontally stretch the SplitView to the options panel (as suggested in the issue)? I feel it looks too wide for this sample.

@niels9001
Copy link
Contributor

/azp run

@marcelwgn
Copy link
Contributor

@marcelwgn Do you think we should horizontally stretch the SplitView to the options panel (as suggested in the issue)? I feel it looks too wide for this sample.

I agree that it would look if we stretch it to the options panel. I think we should have a fixed maximum width for it.

Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Changes look good, just a little bit of cleanup is necessary.

@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn enabled auto-merge (squash) October 3, 2025 12:26
@marcelwgn marcelwgn merged commit 01db226 into microsoft:main Oct 3, 2025
2 checks passed
@AndrewKeepCoding AndrewKeepCoding deleted the splitview-issue-fix branch October 3, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SplitView sample needs work for right-alignment

3 participants