Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Mar 6, 2019

This prevents errors where unexpected arguments are passed to the script, e.g. due to an incorrect command like docker run my_image -p 5000:5000 which would pass -p 5000:5000 to the main.py script instead of to the docker run command.

All Submissions:

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Does your PR follow our Code of Conduct?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Does each method or function "do one thing well"? Reviewers may recommend methods be split up for maintainability and testability.

  • Is this code designed to be testable?

  • Is the code documented well?

  • Does your submission pass existing tests (or update existing tests with documentation regarding the change)?

  • Have you added tests to cover your changes?

  • Have you linted your code prior to submission?

  • Have you updated the documentation and README?

  • Is PII treated correctly? In particular, make sure the code is not logging objects or strings that might contain PII (e.g. request headers).

  • Have secrets been stripped before committing?

This prevents errors where unexpected arguments are passed to the
script, e.g. due to an incorrect command like
`docker run my_image -p 5000:5000` which would pass `-p 5000:5000`
to the main.py script instead of to the docker run command.
@c-w
Copy link
Contributor Author

c-w commented Mar 7, 2019

Closing in favor of #295.

@c-w c-w closed this Mar 7, 2019
@c-w c-w deleted the app-cli branch March 7, 2019 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants