allow assign graphControl.Graph = null; #382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivalik
force-pushed
the
allowNullGraph
branch
from
3676292 to
f8270e6
Compare
Author
|
@microsoft-github-policy-service agree |
trivalik
commented
Dec 2, 2024
| if (_drawingGraph == null) return; | ||
| if (_drawingGraph == null) { | ||
| ClearGraphViewer(); | ||
| return; |
Author
There was a problem hiding this comment.
I am just not sure whether GraphChanged/LayoutComplete events should still miss here. In case we do it, should we do also check for RunLayoutAsync?
Contributor
There was a problem hiding this comment.
It could be safer on assigning a null to create an empty graph and process it instead.
trivalik
force-pushed
the
allowNullGraph
branch
from
f8270e6 to
e283d30
Compare
Contributor
|
Msagl is in the middle of a major reshuffling. I am trying to retarget it to .net8.0, .net9.0. I will merge the pull request after the change. |
Contributor
|
I integrated the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just added in MinWpfApp at the end of
MainWindow_Loaded:This lead to a NullReferenceException on reassingment. This is the fix for it.