-
Notifications
You must be signed in to change notification settings - Fork 595
golang: bump Go version to 1.25.0-1; major version update #14511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ PR Check PassedNo critical issues detected in spec file changes. 🤖 AI Analysis Summary:Brief Analysis: The spec file updates largely adjust BuildRequires to “golang < 1.25” and increment release numbers, while ensuring CVE patches remain referenced and applied via %autopatch. 📋 For detailed analysis and recommendations, check the Azure DevOps pipeline logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK -
I feel we should at least get some clarity on what is our steps forward with a few specs that I have a slight concern with.
Summary: Go | ||
Name: golang | ||
Version: 1.23.12 | ||
Version: 1.24.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am taking a look the specs and I have a concern w.r.t a few packages (this is something that caught my eye today):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking this - I believe these packages will need to be patched/updated to be compatible with 1.24/1.25 before we remove the 1.23 spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Andrew :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a full build with this change:
Looks like more details here: https://devblogs.microsoft.com/go/microsoft-go-defaults-to-system-crypto/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking for now due to the package breaks in the full build (see my previous comment).
I'm fine with upgrading to go 1.25 and keeping the 1.23 spec around temporarily, but we will need to sort out the build breaks before merging.
My changes to resolve the build breaks by pinning incompatible packages to golang 1.24 are visible here: https://github.com/microsoft/azurelinux/compare/3.0-dev...anphel/clone-dev/dagood/go-1.25?expand=1 |
fix golang br for dcos-cli and kubernetes try workaround for multus and containerized-data-importer revert ExclusiveArch in containerized-data-importer use recommends for golang-packaging
SPECS/containerized-data-importer/containerized-data-importer.spec
Outdated
Show resolved
Hide resolved
/azurepipelines run |
Azure Pipelines successfully started running 2 pipeline(s). |
Thanks, applied fixes. New buddy build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=918100&view=results |
@dagood, could you please retarget your branch to |
It seems like there are a lot of conflicts if I try to rebase (8 files). I'm not sure how that branch is meant to operate. It seems to me like it would be better/faster if an Azure Linux maintainer does this. |
Here's my attempt at a fasttrack/3.0 port: #14616 |
|
golang-1.24.spec
, adding 1.25, and deleting 1.23.golang golang-1.24
core specs: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=898561&view=resultsImportant
This release adds toolchain telemetry.