Skip to content

Conversation

PawelWMS
Copy link
Collaborator

@PawelWMS PawelWMS commented Aug 15, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

We're adding support for anonymous Azure blob stores in #14494. This change is to help with that work by making the Azure configuration (including login info) exposed during build-time. Since the toolkit requires to be run as root, the user's Azure config is not visible by default, because it's saved under $HOME/.azure and since we're running as root, the home directory is different from the running user's home directory.

Does this affect the toolchain?

No.

Associated issues
Test Methodology
  • Local tests.
  • Budd builds where the toolkit attempts to upload files to a test Azure Storage Account using the new authentication method:

@PawelWMS PawelWMS requested a review from a team as a code owner August 15, 2025 21:15
@microsoft-github-policy-service microsoft-github-policy-service bot added Tools 3.0-dev PRs Destined for AzureLinux 3.0 labels Aug 15, 2025
@PawelWMS PawelWMS force-pushed the pawelwi/passing_az_config branch 3 times, most recently from 0ed8e5b to 77c1d93 Compare August 15, 2025 21:38
@PawelWMS PawelWMS force-pushed the pawelwi/passing_az_config branch from 77c1d93 to 647c2e2 Compare August 15, 2025 22:02
@christopherco christopherco merged commit e3237a2 into 3.0-dev Aug 23, 2025
41 checks passed
@christopherco christopherco deleted the pawelwi/passing_az_config branch August 23, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants