Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Nov 12, 2024

This adds support for additional framework references - Microsoft.AspNetCore.App and Microsoft.WindowsDesktop.App. It is a follow up to #1285

While doing this I also adjusted the data used to generate the package information. I now consider the platformmanifest rather than reference assemblies. This is more accurate since conflict resolution uses the platform manifest for runtime assemblies. I also improved the reduction algorithm to remove duplicates.

I added tests for these scenarios as well as for a "missing framework" scenario. The latter made me realize we might write to the cache of package information and I modified it to use ConcurrentDictionaries.

@grvillic

This adds support for additional framework references -
Microsoft.AspNetCore.App and Microsoft.WindowsDesktop.App

While doing this I also adjusted the data used to generate the package
information.  I now consider the platformmanifest rather than reference
assemblies.  This is more accurate since conflict resolution uses the
platform manifest for runtime assemblies.  I also improved the reduction
algorithm to remove duplicates.

I added tests for these scenarios as well as for a "missing framework"
scenario.  The latter made me realize we might write to the cache of
package information and I modified it to use ConcurrentDictionaries.
@ericstj ericstj requested a review from a team as a code owner November 12, 2024 01:03
@ericstj ericstj requested a review from pauld-msft November 12, 2024 01:03
@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 98.62543% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (60c6b90) to head (e896df2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ctors/nuget/FrameworkPackages/FrameworkPackages.cs 79.5% 14 Missing and 3 partials ⚠️
...get/NuGetPackageReferenceFrameworkAwareDetector.cs 80.0% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1300     +/-   ##
=======================================
+ Coverage   89.1%   89.6%   +0.4%     
=======================================
  Files        378     378             
  Lines      28659   29907   +1248     
  Branches    1828    1837      +9     
=======================================
+ Hits       25553   26806   +1253     
+ Misses      2716    2707      -9     
- Partials     390     394      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic merged commit 9408a0e into microsoft:main Nov 14, 2024
20 of 23 checks passed
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants