Skip to content

Conversation

@sebasgomez238
Copy link
Contributor

Add NuGet to control group of the experiments. Support was already added here: #1548

Also changes logic to only report telemetry if something was found in the experiment group.

@sebasgomez238 sebasgomez238 requested a review from a team as a code owner December 11, 2025 16:01
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.0%. Comparing base (4c6c5b3) to head (2b81039).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1595   +/-   ##
=====================================
  Coverage   90.0%   90.0%           
=====================================
  Files        435     435           
  Lines      37057   37107   +50     
  Branches    2298    2299    +1     
=====================================
+ Hits       33375   33426   +51     
  Misses      3209    3209           
+ Partials     473     472    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes two adjustments to the LinuxApplicationLayerExperiment: (1) adds NuGetComponentDetector to the control group to align with the experiment detector's existing NuGet support added in PR #1548, and (2) modifies the telemetry recording logic to only report results when the experiment group detector finds components.

Key Changes

  • Adds NuGetComponentDetector to the control group detectors list
  • Changes ShouldRecord from always returning true to conditional logic that returns false when LinuxApplicationLayerDetector finds no components

@sebasgomez238 sebasgomez238 marked this pull request as draft December 11, 2025 16:40
Copilot AI review requested due to automatic review settings December 11, 2025 17:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/LinuxApplicationLayerExperiment.cs:14

  • The class documentation should be updated to include NuGet detectors since they are now part of the control group. The comment currently only mentions "npm and pip detectors" but should also reference NuGet detectors to accurately reflect the changes in this PR.
/// <summary>
/// Experiment to validate the <see cref="LinuxApplicationLayerDetector"/> which captures application-level
/// packages in addition to system packages from Linux containers.
/// Control group includes the standard file-based npm and pip detectors plus the Linux system package detector.
/// Experiment group uses container-based detection for all package types together.
/// </summary>

@sebasgomez238 sebasgomez238 marked this pull request as ready for review December 11, 2025 18:04
@sebasgomez238 sebasgomez238 merged commit f254244 into main Dec 11, 2025
24 of 27 checks passed
@sebasgomez238 sebasgomez238 deleted the users/segomez/linux-fixes branch December 11, 2025 22:29
@github-actions
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants