-
Notifications
You must be signed in to change notification settings - Fork 113
LinuxApplicationLayerExperiment adjustments. #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
=====================================
Coverage 90.0% 90.0%
=====================================
Files 435 435
Lines 37057 37107 +50
Branches 2298 2299 +1
=====================================
+ Hits 33375 33426 +51
Misses 3209 3209
+ Partials 473 472 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes two adjustments to the LinuxApplicationLayerExperiment: (1) adds NuGetComponentDetector to the control group to align with the experiment detector's existing NuGet support added in PR #1548, and (2) modifies the telemetry recording logic to only report results when the experiment group detector finds components.
Key Changes
- Adds NuGetComponentDetector to the control group detectors list
- Changes ShouldRecord from always returning true to conditional logic that returns false when LinuxApplicationLayerDetector finds no components
...osoft.ComponentDetection.Orchestrator/Experiments/Configs/LinuxApplicationLayerExperiment.cs
Show resolved
Hide resolved
...osoft.ComponentDetection.Orchestrator/Experiments/Configs/LinuxApplicationLayerExperiment.cs
Show resolved
Hide resolved
...osoft.ComponentDetection.Orchestrator/Experiments/Configs/LinuxApplicationLayerExperiment.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/Microsoft.ComponentDetection.Orchestrator/Experiments/Configs/LinuxApplicationLayerExperiment.cs:14
- The class documentation should be updated to include NuGet detectors since they are now part of the control group. The comment currently only mentions "npm and pip detectors" but should also reference NuGet detectors to accurately reflect the changes in this PR.
/// <summary>
/// Experiment to validate the <see cref="LinuxApplicationLayerDetector"/> which captures application-level
/// packages in addition to system packages from Linux containers.
/// Control group includes the standard file-based npm and pip detectors plus the Linux system package detector.
/// Experiment group uses container-based detection for all package types together.
/// </summary>
...osoft.ComponentDetection.Orchestrator/Experiments/Configs/LinuxApplicationLayerExperiment.cs
Show resolved
Hide resolved
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Add NuGet to control group of the experiments. Support was already added here: #1548
Also changes logic to only report telemetry if something was found in the experiment group.