v1.8.4 release #274
Merged
v1.8.4 release #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a version release pull request that updates the Azure Synapse dbt adapter to version 1.8.4, focusing on credential handling improvements, dependency updates, and test suite adjustments.
- Added configurable
login_timeoutparameter support to Azure credential authentication methods - Updated dependency constraints and version numbers for compatibility
- Skipped unsupported incremental model tests and temporarily disabled flaky source tests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dbt/adapters/synapse/version.py | Updated version from 1.8.2 to 1.8.4 |
| dbt/adapters/synapse/synapse_connection_manager.py | Added login_timeout parameter support to credential methods |
| setup.py | Restricted dbt-fabric dependency to <1.9.6 for compatibility |
| tests/functional/adapter/test_grants.py | Skipped incremental model grant tests as they're not supported |
| tests/functional/adapter/test_sources.py | Fixed source naming and temporarily skipped tests |
| tests/conftest.py | Added authentication parameter to test profile |
| .python-version | Updated Python version to 3.11.9 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
@colin-rogers-dbt , please approve and I will cut a release. |
colin-rogers-dbt
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Azure Synapse dbt adapter to improve credential handling, update dependencies, and make several test-related adjustments. The most significant changes include adding support for configurable login timeouts on Azure credentials, updating dependency versions, and skipping unsupported incremental model tests.
Credential Handling Improvements:
get_cli_access_token,get_auto_access_token, andget_environment_access_tokenfunctions insynapse_connection_manager.pyto support a configurablelogin_timeoutparameter from credentials, improving robustness for slow authentication scenarios. [1] [2] [3]Dependency Updates:
__version__.pyfrom1.8.2to1.8.4.dbt-fabricdependency insetup.pyto<1.9.6(was<1.10.0) for compatibility..python-versionto3.11.9.Test Suite Adjustments:
test_grants.pybecause incremental models are not supported.authenticationto test profile configuration inconftest.pyfor improved test flexibility.test_sources.pyfor consistency and to address test flakiness. [1] [2]