Skip to content

Fix typo in DirectionalHint Callout type #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix typo in DirectionalHint Callout type #3648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef302ae
Fix directional hint typo
lawrencewin Jun 7, 2024
4a037e2
Change files
lawrencewin Jun 7, 2024
7596f90
Add missing file
lawrencewin Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-callout-50213cd4-3583-401a-b8cc-d16cde4e24bc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix typo in `DirectionalHint` type",
"packageName": "@fluentui-react-native/callout",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-native-contextual-menu-b276b61c-0bd8-4a39-a199-ddc13dee546a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix typo in `DirectionalHint` type",
"packageName": "@fluentui-react-native/contextual-menu",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/components/Callout/macos/FRNCalloutManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ + (NSRect)screenRect:(id)json
@"rightTopEdge": @(NSRectEdgeMaxX),
@"rightCenter": @(NSRectEdgeMaxX),
@"rightBottomEdge": @(NSRectEdgeMaxX),
@"bottonLeftEdge": @(NSRectEdgeMinY),
@"bottomLeftEdge": @(NSRectEdgeMinY),
@"bottomAutoEdge": @(NSRectEdgeMinY),
@"bottomCenter": @(NSRectEdgeMinY),
@"bottomRightEdge": @(NSRectEdgeMinY),
Expand Down
2 changes: 1 addition & 1 deletion packages/components/Callout/src/Callout.settings.macos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const settings: IComposeSettings<ICalloutType> = [
borderColor: 'transparent',
borderWidth: 0,
borderRadius: 5,
directionalHint: 'bottonLeftEdge',
directionalHint: 'bottomLeftEdge',
},
root: {
style: {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/Callout/src/Callout.settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const settings: IComposeSettings<ICalloutType> = [
beakWidth: 20,
borderColor: 'bodyFrameBackground',
borderWidth: 1,
directionalHint: 'bottonLeftEdge',
directionalHint: 'bottomLeftEdge',
gapSpace: 0,
minPadding: 0,
},
Expand Down
2 changes: 1 addition & 1 deletion packages/components/Callout/src/Callout.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export type DirectionalHint =
| 'rightTopEdge'
| 'rightCenter'
| 'rightBottomEdge'
| 'bottonLeftEdge'
| 'bottomLeftEdge'
| 'bottomAutoEdge'
| 'bottomCenter'
| 'bottomRightEdge';
Expand Down
4 changes: 2 additions & 2 deletions packages/components/Callout/src/CalloutNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ export interface NativeProps extends ViewProps {
| 'rightTopEdge'
| 'rightCenter'
| 'rightBottomEdge'
| 'bottonLeftEdge'
| 'bottomLeftEdge'
| 'bottomAutoEdge'
| 'bottomCenter'
| 'bottomRightEdge',
'bottonLeftEdge'
'bottomLeftEdge'
>;
dismissBehaviors?: string[];
doNotTakePointerCapture?: boolean;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/Callout/src/MacOSCalloutNativeComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface NativeProps extends ViewProps {
| 'rightTopEdge'
| 'rightCenter'
| 'rightBottomEdge'
| 'bottonLeftEdge'
| 'bottomLeftEdge'
| 'bottomAutoEdge'
| 'bottomCenter'
| 'bottomRightEdge',
Expand Down
2 changes: 1 addition & 1 deletion packages/components/ContextualMenu/src/ContextualMenu.settings.macos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { contextualMenuName } from './ContextualMenu.types';
export const settings: IComposeSettings<ContextualMenuType> = [
{
tokens: {
directionalHint: I18nManager.isRTL ? 'bottomRightEdge' : 'bottonLeftEdge',
directionalHint: I18nManager.isRTL ? 'bottomRightEdge' : 'bottomLeftEdge',
},
container: {
style: {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/ContextualMenu/src/ContextualMenu.settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const settings: IComposeSettings<ContextualMenuType> = [
beakWidth: 20,
borderColor: 'buttonBorder',
borderWidth: 1,
directionalHint: 'bottonLeftEdge',
directionalHint: 'bottomLeftEdge',
gapSpace: 0,
minPadding: 0,
},
Expand Down