fix(react-charts): remedy bundling all fluent tokens #35416
Closed
+120
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
force-pushed
the
charts-bundle-size-issues
branch
from
9e31883 to
3db87e5
Compare
Hotell
force-pushed
the
charts-bundle-size-issues
branch
from
3db87e5 to
1806203
Compare
|
Pull request demo site: URL |
📊 Bundle size report
Unchanged fixtures
|
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| import * as React from 'react'; | ||
| import { useAreaChartStyles } from './useAreaChartStyles.styles'; | ||
| import { max as d3Max, bisector } from 'd3-array'; |
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 553 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 674 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium.png | 391 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 479 | Changed |
vr-tests-react-components/Charts-Legend 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-Legend.Overflow - Dark Mode.expanded.chromium.png | 1711 | Changed |
vr-tests-react-components/Charts-LineChart 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-LineChart.Basic - Dark Mode.hover.chromium.png | 3131 | Changed |
| vr-tests-react-components/Charts-LineChart.Basic - Dark Mode.default.chromium.png | 4234 | Changed |
| vr-tests-react-components/Charts-LineChart.Events - Dark Mode.default.chromium.png | 5582 | Changed |
| vr-tests-react-components/Charts-LineChart.Gaps - Dark Mode.default.chromium.png | 6861 | Changed |
| vr-tests-react-components/Charts-LineChart.Multiple - Dark Mode.default.chromium.png | 20990 | Changed |
vr-tests-react-components/Drawer 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Drawer.overlay drawer full - High Contrast.chromium.png | 13833 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 593 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 593 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled.disabled input hover.chromium.png | 678 | Changed |
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 659 | Changed |
There were 3 duplicate changes discarded. Check the build logs for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
This is a quick test to see bundle size impact when
tokensare used as expected - the implementation is incorrect ( should be obtained from provider etc )Related Issue(s)