chore: migrate v9 packages to use eslint flat configs #35418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
eca3be2 to
7d548f5
Compare
📊 Bundle size report
Unchanged fixtures
|
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
2 times, most recently
from
4716d92 to
5897acd
Compare
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
change/@fluentui-babel-preset-global-context-705679a5-80b4-48f7-bb30-1a11814f14da.json
Show resolved
Hide resolved
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
5897acd to
7d55897
Compare
mainframev
commented
Nov 3, 2025
packages/react-components/component-selector-preview/stories/package.json
Outdated
Show resolved
Hide resolved
mainframev
commented
Nov 3, 2025
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
57e4027 to
0971f0d
Compare
mainframev
requested review from
a team,
GeoffCoxMSFT,
Mitch-At-Work,
ValentinaKozlova,
chpalac,
dmytrokirpa,
marcosmoura,
ms-acalzaretto and
sopranopillow
as code owners
ValentinaKozlova
approved these changes
Nov 6, 2025
dmytrokirpa
reviewed
Nov 10, 2025
packages/react-components/babel-preset-global-context/eslint.config.js
Outdated
Show resolved
Hide resolved
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
0971f0d to
13fbefb
Compare
Contributor
Author
Since this is temporary, I’m leaning toward keeping the logic in the npm scripts while we migrate all repos to flat ESLint configs and continue using the default target command. Later, we can update the workspace plugin to support only the new format. I tried updating it now to run different ESLint commands based on a condition, and that works, but it conflicts with the targetDefaults.lint command. Also, not all apps/packages are covered by the workspace plugin yet. So if I remove the default lint target and rely only on package-level lint scripts, it will work for the v9 packages, but since some packages don’t have their own lint script and there’s no default target anymore - we might lose lint coverage for some packages. 🤔 "apps/rit-tests-v9/*",
"apps/rit-tests-v8/*",
"tools/**/*",
"scripts/**/*",
"packages/eslint-plugin/**",
"packages/tokens/**",
"packages/react-conformance/**",
"packages/react-components/**/*",
"packages/charts/react-charts/**/*",
"packages/foundation-legacy/**",
"packages/jest-serializer-merge-styles/**",
"packages/react/**",
"packages/react-cards/**",
"packages/react-hooks/**",
"packages/react-focus/**",
"packages/react-examples/**",
"packages/react-experiments/**",
"packages/react-window-provider/**",
"packages/react-icon-provider/**",
"packages/charts/react-charting/**",
"packages/utilities/**",
"packages/react-icons-mdl2/**",
"packages/react-monaco-editor/**",
"packages/react-docsite-components/**",
"packages/react-file-type-icons/** |
Contributor
Not sure I understand the issue you're facing, but here is what I meant and it works without any 
|
dmytrokirpa
reviewed
Nov 11, 2025
Contributor
Author
I had it done almost in the same way, except it was passed to command, not to option.command and I guess that's why it did not work for me. I will check, thanks |
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
13fbefb to
38e2c60
Compare
dmytrokirpa
reviewed
Nov 11, 2025
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
38e2c60 to
23dacd9
Compare
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
37a6a25 to
6abd22b
Compare
…ppropriate eslint cmd
mainframev
force-pushed
the
chore/migrate-to-eslint-flat-configs
branch
from
8609d48 to
f639dca
Compare
dmytrokirpa
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates multiple Fluent UI packages by migrating their linting configuration to use the new ESLint flat config format
workspace generator
create-packagewill be updated in a follow-up PRpartially implements #32289