bulkcopy: fix column escaping #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 74.82% 74.91% +0.09%
==========================================
Files 32 32
Lines 6466 6467 +1
==========================================
+ Hits 4838 4845 +7
+ Misses 1337 1333 -4
+ Partials 291 289 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // This example shows the usage of Connector type | ||
| func ExampleLastInsertId() { | ||
| func ExampleResult_LastInsertId() { | ||
|
|
There was a problem hiding this comment.
why this name change?
There was a problem hiding this comment.
because of new test analyzer behaviour:
https://go.dev/doc/go1.24#vet
https://go.dev/blog/examples#example-function-names
The new tests analyzer reports common mistakes in declarations of tests, fuzzers, benchmarks, and examples in test packages, such as malformed names, incorrect signatures, or examples that document non-existent identifiers. Some of these mistakes may cause tests not to run. This analyzer is among the subset of analyzers that are run by go test. See: https://go.dev/doc/go1.24#vet https://go.dev/blog/examples#example-function-names
dlapko
force-pushed
the
fix-column-escaping
branch
from
f5fd314 to
1444147
Compare
apoorvdeshmukh
approved these changes
Apr 28, 2025
|
@shueybubbles Is there something wrong with the test environment? The linter is failing. |
|
@dlapko can you resolve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.