Update dependencies to fix panic in go generate

[mat007]

I picked Go 1.22 because I’ve seen this in another recent PR run:

Setup go version spec oldstable
oldstable version resolved as 1.22.10

Also updating golang.org/x/tools/cmd/stringer requires Go 1.22:

$ GOTOOLCHAIN=go1.21.0 go get golang.org/x/tools/cmd/stringer
go: golang.org/x/tools/cmd/stringer: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.0; GOTOOLCHAIN=go1.21.0)

Here is what I did:

GOTOOLCHAIN=go1.22.0 go get golang.org/x/tools/cmd/stringer
GOTOOLCHAIN=go1.22.0 go mod tidy

then manually edited go.mod to remove the added toolchain, and re-ran go mod tidy to make sure it’s stable.

[kiashok]

LGTM, thanks!

[thaJeztah]

You can probably remove this one if it automatically added it (go modules tends to randomly add these, but adding also means that users get either down- or upgraded when running commands, so I try to avoid adding these.

[mat007]

Yes, I’ll remove the toolchain.

[thaJeztah]

Did the updated modules enforce updating to go1.22.0, or does it accept staying on go1.21 ?

[mat007]

Yes, it needs go 1.22:

$ GOTOOLCHAIN=go1.21.0 go get golang.org/x/tools/cmd/stringer
go: golang.org/x/tools/cmd/stringer: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.0; GOTOOLCHAIN=go1.21.0)

[mat007]

@kiashok can you trigger the CI again?

[mat007]

All right, so this effectively fixes the «CI / Go Generate» workflow.
Do you folks want to merge this PR as is, or should we cherry-pick this to #325 to fix all workflows in a single PR?

[kiashok]

All right, so this effectively fixes the «CI / Go Generate» workflow. Do you folks want to merge this PR as is, or should we cherry-pick this to #325 to fix all workflows in a single PR?

@mat007 #325 might not fix all the CI issues being hit here right? The interger overflow ones especially - do you want me to look into the integer overflow lint errors? Apologies that a lot of this has fallen on you.

[mat007]

@mat007 #325 might not fix all the CI issues being hit here right? The interger overflow ones especially - do you want me to look into the integer overflow lint errors? Apologies that a lot of this has fallen on you.

Thanks @kiashok ! I can look at the lint errors in that other PR, but I need some guidance on how best to approach it, see #325 (comment)

But also, do we want to merge here, or cherry-pick the commits to #325? I really don’t mind either way. 😄

[mat007]

@kiashok sorry for pinging you again.
Is there any chance we can merge this?