Add support for LX symlinks (0xA000001D) for WSL/MSYS2 compatibility #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
- Add reparseTagLxSymlink constant (0xA000001D) - Implement decode logic for LX symlinks (UTF-8 format) - Add IsLxSymlink field to ReparsePoint struct to preserve symlink type - Implement encode logic to recreate LX symlinks on import - Add unit tests for LX symlink round-trip validation Fixes issue where Docker builds with MSYS2 failed with 'unsupported reparse point a000001d' error. Signed-off-by: Varun Gokulnath <[email protected]>
Signed-off-by: Varun Gokulnath <[email protected]>
vagokuln-msft
force-pushed
the
fix-lx-symlink-support
branch
from
29a5906 to
7b9940e
Compare
Extract LX symlink encode/decode into separate functions for better maintainability and cleaner separation of concerns. Signed-off-by: Varun Gokulnath <[email protected]>
Signed-off-by: Varun Gokulnath <[email protected]>
Author
|
@msscotb @Kishon-Microsoft, could you please review this change? We hope to get this merged soon as it has been a few weeks since the PR was opened. Thanks! |
| dataLength := 4 + len(targetBytes) | ||
|
|
||
| var b bytes.Buffer | ||
| _ = binary.Write(&b, binary.LittleEndian, uint32(reparseTagLxSymlink)) |
There was a problem hiding this comment.
Any specific reason for discarding the errors?
| // mount point. | ||
| // EncodeReparsePoint encodes a Win32 REPARSE_DATA_BUFFER structure describing a symlink, | ||
| // mount point, or LX symlink. | ||
| func EncodeReparsePoint(rp *ReparsePoint) []byte { |
There was a problem hiding this comment.
Can we guard against passing a nil value?
| "testing" | ||
| ) | ||
|
|
||
| func TestLxSymlinkRoundTrip(t *testing.T) { |
There was a problem hiding this comment.
Can we add tests for other scenarios? atleast with empty Target?
|
|
||
| func encodeLxReparsePoint(rp *ReparsePoint) []byte { | ||
| // LX symlink: 4-byte version + UTF-8 target | ||
| version := uint32(2) |
There was a problem hiding this comment.
Adding something like const lxSymlinkVersion = 2 and then using it here would be clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for LX symlinks (IO_REPARSE_TAG_LX_SYMLINK, tag 0xA000001D) used by WSL and MSYS2 for native Unix-style symlinks.
Problem
Docker builds using MSYS2 with native symlinks (MSYS=winsymlinks:native) fail with error "unsupported reparse point a000001d" because go-winio doesn't recognize LX symlink reparse tags.
Solution
reparseTagLxSymlinkconstant (0xA000001D)IsLxSymlinkfield to preserve symlink type through encode/decode cyclesTesting