Drop version requirement in test/CMakeLists.txt #1165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required versioned isn't synced with the installed version, making it impossible to run the stand-alone tests without patching the source. OTOH CMake lets the user inject the desired config location, and the found version can be reported.
Author
|
Basically I'm tired of maintaining this as a patch in vcpkg. Nobody else running these tests? |
Author
|
This is how version "progress" in mimalloc-config-version.cmake: |
dg0yt
commented
Nov 1, 2025
| endif() | ||
|
|
||
| # Import mimalloc (if installed) | ||
| find_package(mimalloc 2.2 CONFIG REQUIRED) |
daanx
added a commit
that referenced
this pull request
Nov 6, 2025
Collaborator
|
Thanks again! I fixed it directly into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required versioned isn't synced with the installed version, making it impossible to run the stand-alone tests without patching the source. OTOH CMake lets the user inject the desired config location, and the found version can be reported.