-
Notifications
You must be signed in to change notification settings - Fork 55
[SLB V2] SLB Proto Update #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9d1926e to
f919bb4
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
madhanrm
previously approved these changes
Sep 30, 2025
f919bb4 to
2fc7eb1
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nijosmsft
reviewed
Oct 29, 2025
rpc/cloudagent/network/loadbalancer/moc_cloudagent_loadbalancer.proto
Outdated
Show resolved
Hide resolved
…endAddressPool, Add RequestPath param for probes
…workInterfaceRef in the BackendAddressPool, moved data to the internalLB
2fc7eb1 to
298c763
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nijosmsft
approved these changes
Nov 6, 2025
adfema
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and new features to the load balancer and network interface protocol buffer definitions, as well as updates to the Go module dependencies. The main focus is on expanding support for advanced load balancer configurations, including outbound NAT rules, probes, frontend IP configurations, and backend address pools, and ensuring these are reflected in both proto and generated Go code. Additionally, some dependency versions have been updated.
Load Balancer Feature Expansion
Added new message types and enums to
moc_cloudagent_loadbalancer.prototo support outbound NAT rules (LoadbalancerOutboundNatRule), load distribution strategies (LoadDistribution), probe protocols (ProbeProtocol), and resource tagging. Also introduced new messages forProbe,FrontEndIpConfiguration, andBackendAddressPool, and expanded theLoadBalancermessage to include these new fields and repeated lists for advanced configuration. [1] [2]Included an
ApiVersionfield inLoadBalancerRequestto support versioning for API requests.Network Interface Feature Expansion
loadBalancerAddressPoolsRefto theIpConfigurationmessage in both the proto file (moc_cloudagent_networkinterface.proto) and the generated Go code, allowing IP configurations to reference multiple backend address pools. [1] [2]LoadBalancerAddressPoolsRefto retrieve these references fromIpConfiguration.Dependency Updates
go.mod, includinggolang.org/x/net,golang.org/x/sys,golang.org/x/text,google.golang.org/genproto/googleapis/rpc, andgoogle.golang.org/protobuf, likely for compatibility with proto changes.Generated Code Synchronization
moc_cloudagent_networkinterface.pb.goto reflect the new and updated proto definitions, increasing the descriptor size and syncing with the new proto schema.