vpci: send completion after device (#1500) #1671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackschefer-msft
approved these changes
Jul 10, 2025
Follow the Hyper-V protocol order and send the FDO D0 entry completion message only after the device description has been sent.
jstarks
force-pushed
the
vpci_ordering_2505
branch
from
3bededd to
12c300d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the vPCI device protocol to follow the Hyper-V protocol order by sending the FDO D0 entry completion message only after the device description has been sent, rather than immediately after the D0 entry is processed.
Key changes:
- Deferred completion message sending in the vPCI protocol state machine
- Added debugging tracing for config space mapping operations
- Updated test infrastructure to handle the new protocol ordering
Comment on lines
+644
to
+645
| if let Some(transaction_id) = self.send_completion { | ||
| conn.send_completion(Some(transaction_id), &protocol::Status::SUCCESS, &[])?; |
There was a problem hiding this comment.
The completion is being sent with Some(transaction_id) but the original code used just transaction_id. This changes the function signature expectation and may cause a type mismatch or incorrect protocol behavior.
Suggested change
| if let Some(transaction_id) = self.send_completion { | |
| conn.send_completion(Some(transaction_id), &protocol::Status::SUCCESS, &[])?; | |
| conn.send_completion(transaction_id, &protocol::Status::SUCCESS, &[])?; |
Copilot uses AI. Check for mistakes.
chris-oo
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the Hyper-V protocol order and send the FDO D0 entry completion message only after the device description has been sent.
Cherry-pick of #1500