Skip to content

wip: Advertise optional flr support #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

wip: Advertise optional flr support #1858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
e4705ce
Ran xtask fmt fix
gurasinghMS Aug 22, 2025
7e25c82
Fixing build issues
gurasinghMS Aug 22, 2025
466655a
Initial plan
Copilot Jul 18, 2025
fa25729
Add Function Level Reset (FLR) support to NVMe emulator
Copilot Jul 18, 2025
45a2414
Address PR feedback: improve PCI Express capability implementation
Copilot Jul 18, 2025
e9ae16b
Added a todo comment to fix the spec
gurasinghMS Aug 12, 2025
e6db4df
Initial plan
Copilot Jul 18, 2025
522058f
Initial plan
Copilot Jul 18, 2025
b8d2e27
Initial plan
Copilot Jul 18, 2025
aaf1411
Moved the flr logic to the nvme fault controller instead of the actua…
gurasinghMS Aug 13, 2025
5848a4e
Fixed the Device Capabilites struct as per the nvme 6.4 spec
gurasinghMS Aug 13, 2025
136537f
Fixed the Device Control struct
gurasinghMS Aug 13, 2025
af2845c
Remove link config and link control since that is options for PCIe de…
gurasinghMS Aug 13, 2025
0446d4b
Moving FLR logic to happen after a CFG write
gurasinghMS Aug 13, 2025
3831510
Rebasing to the Fault builder model style of fault injection
gurasinghMS Aug 23, 2025
efa32f5
Added the find_pci_capability method as a test helper instead of it b…
gurasinghMS Aug 14, 2025
716de0b
Fixing build issues
gurasinghMS Aug 14, 2025
7ad0449
Small changes based on comments. Using builder notation instead of ma…
gurasinghMS Aug 19, 2025
f102776
Repsonding to comments about flr handler creation
gurasinghMS Aug 22, 2025
067c193
Pausing work
gurasinghMS Aug 22, 2025
1efe1a7
Commit before merge
gurasinghMS Aug 22, 2025
3f194fb
Pausing work again. This will be completed after the Fault Configurat…
gurasinghMS Aug 22, 2025
c21cfa4
Fixing build issues
gurasinghMS Aug 23, 2025
8c2141e
Responding to comments and build errors
gurasinghMS Aug 24, 2025
badcf29
Finished the merge and related changes. Back up to speed with the mai…
gurasinghMS Aug 25, 2025
ca9f04e
Merge branch 'main' into advertise_flr_support
gurasinghMS Aug 25, 2025
ecb8160
Apply suggestion from @mattkur
gurasinghMS Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vm/devices/pci/pci_core/src/capabilities/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@

//! PCI capabilities.

pub use self::pci_express::FlrHandler;
pub use self::pci_express::PciExpressCapability;
pub use self::read_only::ReadOnlyCapability;

use inspect::Inspect;
use vmcore::save_restore::ProtobufSaveRestore;

pub mod msix;
pub mod pci_express;
pub mod read_only;

/// A generic PCI configuration space capability structure.
Expand Down
Loading