mesh_protobuf: Fix signed nonzero int oversights #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes oversights in the mesh_protobuf encoding implementation for signed NonZero integer types. The changes ensure proper protobuf encoding support for NonZero types and fix a potential runtime panic when handling default values.
- Adds missing builtin_field_type implementations for signed NonZero integer types
- Fixes unwrap() call that could panic when setting default values for NonZero types
chris-oo
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These impls probably should be here, as these encodings are listed as the default encodings for these types. It's just that nobody uses the NonZero types haha. Also fix the unwrap that will fail for NonZeros.
Found by GPT-5