netvsp: handle RNDIS packet filter OID for stopping Rx (#1873) #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux netvsc sends an OID to stop receiving packets on vmbus channel close. Example scenarios: hibernation and MTU change. Prior to opening a new channel and processing the packets, netvsc checks that there are no pending packets. If there are, netvsc logs and error and is unable to recover. We observe the error: `hv_netvsc eth0: Ring buffer not empty after closing rndis` in the guest syslog. Modifying netvsp to handle the OID and stop processing RX traffic. This will allow for netvsc to successfully close and re-open the vmbus channel, even under heavy incoming traffic. --------- Co-authored-by: Sunil Muthuswamy <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR implements handling of the RNDIS packet filter OID (Object Identifier) to stop Rx traffic when the filter is set to None. This addresses an issue where Linux netvsc fails to properly close and reopen vmbus channels during operations like hibernation and MTU changes, causing the error "Ring buffer not empty after closing rndis".
Key changes:
- Added packet filter state tracking and handling for RNDIS OID_GEN_CURRENT_PACKET_FILTER
- Modified coordinator messaging to handle packet filter updates across all channels
- Added comprehensive test coverage for packet filter functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| vm/devices/net/netvsp/src/lib.rs | Main implementation: added packet filter state, OID handling, coordinator messaging updates, and Rx filtering logic |
| vm/devices/net/netvsp/src/rndisprot.rs | Added packet filter constants and type definitions for RNDIS protocol |
| vm/devices/net/netvsp/src/saved_state.rs | Added packet filter field to saved state for persistence across restarts |
| vm/devices/net/netvsp/src/test.rs | Added comprehensive test for packet filter functionality and updated existing test to include filter setup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux netvsc sends an OID to stop receiving packets on vmbus channel close. Example scenarios: hibernation and MTU change. Prior to opening a new channel and processing the packets, netvsc checks that there are no pending packets. If there are, netvsc logs and error and is unable to recover. We observe the error:
hv_netvsc eth0: Ring buffer not empty after closing rndisin the guest syslog.Modifying netvsp to handle the OID and stop processing RX traffic. This will allow for netvsc to successfully close and re-open the vmbus channel, even under heavy incoming traffic.
Cherry pick of #1873