vmm_tests: storvsp: generate IO to the attached devices #1957
+79
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the storvsp VMM test by adding actual I/O operations to test storage devices more thoroughly. The test previously only verified device presence and sizing but now performs 100MB write operations to both SCSI and NVMe devices to validate their functionality.
Key changes:
- Increased disk sizes from ~4MB to ~128-160MB to accommodate the new I/O operations
- Added comprehensive device enumeration with improved logging and error handling
- Implemented actual I/O testing using
ddcommands to write 100MB to each storage device
|
Wasn't there already a PR for this? |
yes. something happened on my end where I could no longer update that branch. I've closed that out. I also see your feedback about reading the data back. |
gurasinghMS
reviewed
Sep 5, 2025
gurasinghMS
reviewed
Sep 5, 2025
…t are shown through OpenHCL. This also verifies that the data was correctly written to disk. Design choices: - Use `dd`, since that is what's inbox in BusyBox - Ditto for the parameters to `dd` (e.g. it would have been ideal to use `oflags=sync`, but that is not supported by the inbox version of `dd`). - 1MB IOs, for 100MB, is enough to provoke a bug that we saw in other changes.
|
@gurasinghMS , @jstarks - I deprioritized this. I've now cleaned it up. Thanks for the previous reviews; I'm ready for a second look from you. |
chris-oo
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test generates IO against the translated devices. This has found a bug in in-development code, so I believe there is value here.
dd, since that's inbox. 1MB IO matches the IO pattern seen for the bug offline.