chore: use detail/summary for html reporter attachments #36560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
html/attachments/details
branch
from
03d5057 to
d05ed36
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
approved these changes
Jul 4, 2025
agg23
reviewed
Jul 7, 2025
There was a problem hiding this comment.
For changes like this in the future, it is very helpful to include before and after screenshots even if you believe there to be no visual change. There is obviously significant DOM and styling changes here, so helping the reviewer understand there is actually no change would be appreciated.
Otherwise looks good. Given the amount of inline styling and the fact that links.css already exists, I would recommend moving these styles into a stylesheet.
pavelfeldman
reviewed
Jul 7, 2025
mxschmitt
force-pushed
the
html/attachments/details
branch
from
d05ed36 to
20b8b6d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Jul 16, 2025
Test results for "tests 1"8 flaky46752 passed, 926 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
The browser by default when you use the native search functionality only looks at visible nodes. For detail/summary it includes it as well and automatically expands them. This is handy for e.g. attachments (stdout/stderr) in the html reporter. Since we previously didn't use them, the expansion had to be done manually. This PR addresses that so that command + F and search for the query does automatically expand it.
There should be no other UI changes besides that, it should look and behave the same.