Skip to content

chore(html): preserve query params in relative links #38042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

chore(html): preserve query params in relative links #38042

merged 1 commit into from
Oct 29, 2025
+42 −14

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Oct 29, 2025

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@dgozman dgozman requested a review from Skn0tt October 29, 2025 13:30
@github-actions

This comment has been minimized.

Sign in to view
Skn0tt
Skn0tt approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatUrl sounds a little too innocent for what's doing, but i'm struggling to come up with a name that's not a mouthful.

@dgozman dgozman force-pushed the chore-html-keep-query-params branch from 867becc to faffc86 Compare October 29, 2025 14:04
@github-actions
Copy link
Contributor

Test results for "MCP"

2531 passed, 108 skipped

Merge workflow run.

@dgozman dgozman merged commit c3aa5f8 into microsoft:main Oct 29, 2025
32 of 35 checks passed
@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › reporter-html.spec.ts:724 › created › should warn user when viewing via file:// protocol @macos-latest-node18-2

2 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node18`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`

45746 passed, 808 skipped

Merge workflow run.

@rexingQ rexingQ mentioned this pull request Oct 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skn0tt Skn0tt Skn0tt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgozman @Skn0tt