Add support for horizontal mouse wheel events #19248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
aymanbagabas
force-pushed
the
support-hwheel
branch
5 times, most recently
from
e326ed1 to
90a82d4
Compare
lhecker
reviewed
Aug 19, 2025
aymanbagabas
force-pushed
the
support-hwheel
branch
from
90a82d4 to
b9cfb5a
Compare
aymanbagabas
force-pushed
the
support-hwheel
branch
from
b9cfb5a to
cc95e48
Compare
DHowett
reviewed
Sep 10, 2025
DHowett
reviewed
Sep 10, 2025
lhecker
approved these changes
Sep 10, 2025
Comment on lines
508
to
511
| return _sendMouseEventHelper(terminalPosition, | ||
| WM_MOUSEWHEEL, | ||
| delta.X != 0 ? WM_MOUSEHWHEEL : WM_MOUSEWHEEL, | ||
| modifiers, | ||
| ::base::saturated_cast<short>(delta), | ||
| ::base::saturated_cast<short>(delta.X != 0 ? delta.X : delta.Y), |
There was a problem hiding this comment.
Oh interesting... I wonder if we should refactor _sendMouseEventHelper to allow for both X and Y to be passed? You don't have to do this in this PR of course - I can do that as a follow up (or I push into your PR).
There was a problem hiding this comment.
I left it as is because _sendMouseEventHelper is used for other buttons with a delta value of zero. Instead, we should perhaps refactor _core.SendMouseEvent to make it take a Core::Point delta instead of short. However, that feels like a larger endeavor with little to no gain 😕
I will leave the decision to you
j4james
reviewed
Sep 11, 2025
j4james
reviewed
Sep 11, 2025
This adds support for horizontal mouse wheel events (WM_MOUSEHWHEEL). With this change, applications running in the terminal can now receive and respond to horizontal scroll inputs from the mouse/trackpad. Fixes: microsoft#19245
Co-authored-by: Dustin L. Howett <[email protected]>
aymanbagabas
force-pushed
the
support-hwheel
branch
from
f28d525 to
f6b7631
Compare
aymanbagabas
force-pushed
the
support-hwheel
branch
from
f6b7631 to
e53f03e
Compare
j4james
reviewed
Sep 11, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ap run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@DHowett Could you please rerun the pipeline? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
j4james
approved these changes
Sep 11, 2025
DHowett
approved these changes
Sep 11, 2025
DHowett
pushed a commit
that referenced
this pull request
Sep 16, 2025
This adds support for horizontal mouse wheel events (`WM_MOUSEHWHEEL`). With this change, applications running in the terminal can now receive and respond to horizontal scroll inputs from the mouse/trackpad. Closes #19245 Closes #10329 (cherry picked from commit 814f78e) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgep1sM Service-Version: 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds support for horizontal mouse wheel events (WM_MOUSEHWHEEL). With this change, applications running in the terminal can now receive and respond to horizontal scroll inputs from the mouse/trackpad.
References and Relevant Issues
Closes #19245
Closes #10329
Validation Steps Performed
Tested terminal applications that receive horizontal mouse wheel events.
PR Checklist