Skip to content

Conversation

dofuuz
Copy link
Contributor

@dofuuz dofuuz commented Aug 30, 2025

  • Add Selection BG color
  • Make Bright white brighter

Summary of the Pull Request

Final tune for Dimidium color scheme before its release.

References and Relevant Issues

#18563

Detailed Description of the Pull Request / Additional comments

I made little change to Dimidium color scheme.

cmp-lightness1c

preview-terminal

image
  • Adjusted "Bright white" slightly brighter, hoping it can be distinguished better from "White".
  • Defined "Selection Background" color.

This will be the final tune for Dimidum color scheme.

- Add Selection BG color
- Make Bright white brighter
@DHowett
Copy link
Member

DHowett commented Aug 30, 2025

Woo, thanks so much! I'll mark this one up for inclusion in 1.24 so that when it goes stable it's updated there too.

Wondering if I should backport the entire theme into the 1.23 Stable release...

@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.23 Servicing Pipeline Aug 30, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.24 Servicing Pipeline Aug 30, 2025
@DHowett DHowett moved this from To Cherry Pick to To Consider in 1.23 Servicing Pipeline Aug 30, 2025
@ehoogeveen-medweb
Copy link

I was checking out the new theme, and the other thing that stood out to me as lacking contrast is the -w in diff -w:
image
Compare Ottosson:
image
While I wouldn't want the -w to be too dim as that would make it hard to read, it's hard to see that it's a different shade of gray at all with the current scheme :)

@dofuuz
Copy link
Contributor Author

dofuuz commented Sep 2, 2025

@ehoogeveen-medweb Are you using 'Automatically adjust lightness of indistinguishable text' option?

@ehoogeveen-medweb
Copy link

Ah, I was! I didn't realize that would have an effect on it. Yes, setting that back to "Automatic" makes the -w much more distinct:
image

@DHowett DHowett merged commit 8011f3e into microsoft:main Sep 3, 2025
15 checks passed
@DHowett DHowett moved this from To Consider to To Cherry Pick in 1.23 Servicing Pipeline Sep 5, 2025
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.23 Servicing Pipeline Sep 5, 2025
DHowett pushed a commit that referenced this pull request Sep 5, 2025
- Add Selection BG color
- Make Bright white brighter

## Summary of the Pull Request
Final tune for Dimidium color scheme before its release.

## References and Relevant Issues
#18563

## Detailed Description of the Pull Request / Additional comments
I made little change to Dimidium color scheme.

<img width="640" height="174" alt="cmp-lightness1c"
src="https://github.com/user-attachments/assets/2e4aa6ca-5864-4901-b323-2e2bb2bf00e8"
/>

![preview-terminal](https://github.com/user-attachments/assets/8a53c54d-942a-44a2-9ee7-9ff8a6d2dfab)

<img width="584" height="207" alt="image"
src="https://github.com/user-attachments/assets/b70b0759-7961-4f8f-aaa7-762fc48e425b"
/>

- Adjusted "Bright white" slightly brighter, hoping it can be
distinguished better from "White".
- Defined "Selection Background" color.

This will be the final tune for Dimidum color scheme.

(cherry picked from commit 8011f3e)
Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgeMuoU
Service-Version: 1.23
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.24 Servicing Pipeline Sep 5, 2025
DHowett pushed a commit that referenced this pull request Sep 5, 2025
- Add Selection BG color
- Make Bright white brighter

## Summary of the Pull Request
Final tune for Dimidium color scheme before its release.

## References and Relevant Issues
#18563

## Detailed Description of the Pull Request / Additional comments
I made little change to Dimidium color scheme.

<img width="640" height="174" alt="cmp-lightness1c"
src="https://github.com/user-attachments/assets/2e4aa6ca-5864-4901-b323-2e2bb2bf00e8"
/>

![preview-terminal](https://github.com/user-attachments/assets/8a53c54d-942a-44a2-9ee7-9ff8a6d2dfab)

<img width="584" height="207" alt="image"
src="https://github.com/user-attachments/assets/b70b0759-7961-4f8f-aaa7-762fc48e425b"
/>

- Adjusted "Bright white" slightly brighter, hoping it can be
distinguished better from "White".
- Defined "Selection Background" color.

This will be the final tune for Dimidum color scheme.

(cherry picked from commit 8011f3e)
Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgeMuoQ
Service-Version: 1.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Cherry Picked
Status: Cherry Picked
Development

Successfully merging this pull request may close these issues.

3 participants