fix(1374): support declaration emit for expando functions #1399
+1,028
−356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-tarasyuk
force-pushed
the
fix/1374
branch
11 times, most recently
from
698d40d to
c063ac4
Compare
jakebailey
reviewed
Jul 14, 2025
jakebailey
reviewed
Jul 14, 2025
...elines/reference/submodule/compiler/declarationEmitDefaultExportWithStaticAssignment.js.diff
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Jul 14, 2025
testdata/baselines/reference/submodule/compiler/declarationEmitLateBoundAssignments.js.diff
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Jul 14, 2025
testdata/baselines/reference/submodule/compiler/declarationEmitFunctionKeywordProp.js.diff
Show resolved
Hide resolved
jakebailey
reviewed
Jul 14, 2025
testdata/baselines/reference/submodule/compiler/declarationEmitLateBoundJSAssignments.js.diff
Show resolved
Hide resolved
jakebailey
reviewed
Jul 14, 2025
...ata/baselines/reference/submodule/compiler/jsxDeclarationsWithEsModuleInteropNoCrash.js.diff
Show resolved
Hide resolved
weswigham
reviewed
Jul 14, 2025
There was a problem hiding this comment.
This looks like a pretty straight port of the logic from strada - @sandersn should weigh in on weather he thinks that's right. I do not recall if these is one of the constructs that changed meaningfully in the js reparser rewrite and, thus, should also have it's declaration emit logic adjusted, too.
weswigham
reviewed
Jul 14, 2025
|
Expandos didn't fundamentally change, but they are losing a lot of their complicated features. So the core changes to emit might be right-ish, but you won't need to reintroduce any code in the parser or binder, I think. |
|
@sandersn Thanks for the clarification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.