Port many more fourslash functions #2339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request ports several fourslash test helper functions from the TypeScript reference implementation to enable more comprehensive testing. The PR adds 8 new test assertion functions and updates baselines for multiple existing fourslash tests, particularly for goToDefinition, findRenameLocations, findAllReferences, quickInfo, and documentSymbols features.
Key Changes:
- Added 8 new fourslash assertion functions:
numberOfErrorsInCurrentFile,noErrors,errorExistsAtRange,currentLineContentIs,currentFileContentIs,errorExistsBetweenMarkers,errorExistsAfterMarker, anderrorExistsBeforeMarker - Generated/updated 100+ test files using these new functions
- Updated baseline files to reflect improved test output formatting and behavior convergence with the TypeScript reference implementation
Reviewed changes
Copilot reviewed 290 out of 290 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/fourslash/tests/gen/*_test.go |
Generated test files using the newly ported fourslash functions for error checking, content verification, and test assertions |
testdata/baselines/reference/**/*.baseline* |
Updated baseline files showing improved convergence with TypeScript reference implementation, particularly for goToDefinition, rename, and reference finding features |
gabritto
reviewed
Dec 11, 2025
gabritto
approved these changes
Dec 11, 2025
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
Left an optional comment, but this looks good, thanks! And many more tests to fix... 🙂
gabritto
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on another missing thing and there were some tests missing. So, add:
numberOfErrorsInCurrentFilenoErrorserrorExistsAtRangecurrentLineContentIscurrentFileContentIserrorExistsBetweenMarkerserrorExistsAfterMarkererrorExistsBeforeMarker