Skip to content

feat: Azure URL validation #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: Azure URL validation #1463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d6c398
feat: Azure URL validation
AAAkater Oct 21, 2025
22b7b66
Merge branch 'main' into feat/Azure-URL-validate
AAAkater Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/extension/byok/vscode-node/customOAIModelConfigurator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Config, ConfigKey, IConfigurationService } from '../../../platform/conf
import { EndpointEditToolName } from '../../../platform/endpoint/common/endpointProvider';
import { DisposableStore } from '../../../util/vs/base/common/lifecycle';
import { BYOKModelProvider } from '../common/byokProvider';

import { AzureBYOKModelProvider, resolveAzureUrl } from "./azureProvider";
interface ModelConfig {
name: string;
url: string;
Expand Down Expand Up @@ -42,7 +42,7 @@ export class CustomOAIModelConfigurator {
private readonly _provider: BYOKModelProvider<LanguageModelChatInformation>

) {
if (_vendor === 'azure') {
if (_vendor === AzureBYOKModelProvider.providerName.toLowerCase()) {
this._forceRequiresAPIKey = true;
this._configKey = ConfigKey.AzureModels;
}
Expand Down Expand Up @@ -238,15 +238,19 @@ export class CustomOAIModelConfigurator {
prompt: 'Enter the API endpoint URL',
placeHolder: 'e.g., https://api.openai.com or https://my-api.example.com/v1',
validateInput: (value) => {
if (!value.trim()) {
value = value.trim();
if (!value) {
return 'URL cannot be empty';
}
try {
new URL(value.trim());
return null;
} catch {
return 'Please enter a valid URL';
new URL(value);
if (this._vendor === AzureBYOKModelProvider.providerName.toLowerCase()) {
const url = resolveAzureUrl(this._configKey.id, value);
}
} catch (e) {
return e;
}
return null;
}
});

Expand Down