activeCallback uses waitForQueuedToInProgress #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ports changes from the vscode-pull-request-github repository to handle sessions in both 'queued' and 'in_progress' states. The key improvement is ensuring that the active response callback waits for queued sessions to transition to in_progress before streaming logs, preventing premature handling of sessions that haven't started yet.
Key Changes:
- Modified
createActiveResponseCallbackto wait for queued sessions to transition to in_progress - Updated session state checks to include both 'queued' and 'in_progress' states
- Added better logging and error handling for session state transitions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/extension/chatSessions/vscode-node/copilotCloudSessionsProvider.ts |
Added waitForQueuedToInProgress call in active callback, renamed variable for clarity, and improved state transition handling with additional logging |
src/extension/chatSessions/vscode-node/copilotCloudSessionContentBuilder.ts |
Extended placeholder response logic to handle queued sessions in addition to in-progress sessions |
src/extension/chatSessions/vscode-node/copilotCloudSessionsProvider.ts
Outdated
Show resolved
Hide resolved
rebornix
previously approved these changes
Oct 24, 2025
Tyriar
previously approved these changes
Oct 24, 2025
rebornix
approved these changes
Oct 24, 2025
joshspicer
added a commit
that referenced
this pull request
Oct 25, 2025
* activeCallback uses waitForQueuedToInProgres (related microsoft/vscode-pull-request-github@503e2b3) * do not await attaching to in progress session during creation * bring back null check
rebornix
pushed a commit
that referenced
this pull request
Oct 25, 2025
* activeCallback uses waitForQueuedToInProgres (related microsoft/vscode-pull-request-github@503e2b3) * do not await attaching to in progress session during creation * bring back null check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port over microsoft/vscode-pull-request-github@503e2b3