Limit placeholder view visibility #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logic controlling when the Codex placeholder view is shown in the chat panel. The key change is adding a check for whether the user has Codex agent access before displaying the placeholder view.
Key Changes:
- Added authentication and configuration service dependencies to check user's Codex agent access
- Renamed context key from
codex.notInstalledtocodex.showPlaceholderto better reflect its purpose - Introduced conditional logic that only shows the placeholder when both the user has access AND the extension is not installed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/extension/contextKeys/vscode-node/placeholderView.contribution.ts | Added authentication/configuration checks and renamed context key to control placeholder visibility based on user access |
| package.json | Updated context key reference in view contribution to match renamed key |
| "id": "codex-placeholder", | ||
| "name": "OpenAI Codex Agent", | ||
| "when": "github.copilot.chat.codex.notInstalled && config.chat.experimental.codex.enabled", | ||
| "when": "github.copilot.chat.codex.showPlaceholder && config.chat.experimental.codex.enabled", |
There was a problem hiding this comment.
The config.chat.experimental.codex.enabled check is now redundant since it's already evaluated in the TypeScript code when setting enabledForUser. Consider removing it from the when clause to avoid duplicate logic.
Suggested change
| "when": "github.copilot.chat.codex.showPlaceholder && config.chat.experimental.codex.enabled", | |
| "when": "github.copilot.chat.codex.showPlaceholder", |
dmitrivMS
approved these changes
Oct 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
roblourens
added a commit
that referenced
this pull request
Oct 25, 2025
* Limit placeholder view visibility * Efficiency
roblourens
added a commit
that referenced
this pull request
Oct 25, 2025
Limit placeholder view visibility (#1598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.