avoid runtime SHA-256 for 'grok-code' model #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the runtime SHA-256 comparison in `isHiddenModelB` with a direct plain-family equality check for the known model family "grok-code". This removes unnecessary crypto overhead for the common case and ensures the function always returns a boolean Promise.
|
We would likely want to remove the isHiddenModel function all together since this model is no longer hidden. Then you would just inline grok code with the rest of the checks that this function was calling into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the runtime SHA-256 comparison in
isHiddenModelBwith a direct plain-family equality check for the known model family "grok-code". This removes unnecessary crypto overhead and ensures the function always returns a boolean Promise.