Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions #901

FluoriteCafe-work · 2025-09-03T04:20:29Z

Components for Java engine/dependency upgrade reminder.

FluoriteCafe-work · 2025-09-03T04:26:42Z

@microsoft-github-policy-service agree company="Microsoft"

wangmingliang-ms · 2025-09-03T05:29:21Z

src/views/workspaceNode.ts

-        return Jdtls.getProjects(this.nodeData.uri);
+        const result = await Jdtls.getProjects(this.nodeData.uri);
+        PromotionProvider.getInstance().checkJavaVersion(result);
+        return result;


what if this method is called >1 times?

The loadData function should only handle data retrieval. Performing a Java version validation at the same time as data fetching seems quite unreasonable. This is clearly a "side effect" and should be avoided.

what if this method is called >1 times?

Controls are implemented in a downstream function to prevent repeated notifications.

The loadData function should only handle data retrieval.

I'll seek to move the added logic out of loadData().

I've updated the PR to check Java version on creation of ProjectNode (new ProjectNode(...)) - Java version is related to this type of node. Outside the scope the Java version data is hard to be read (it's saved in a protected property) without touching the property structure of classes.

akaroml

Please detect whether the App Mod ext is active. If it's inactive, no hint should be shown to the users.

akaroml · 2025-09-10T03:38:01Z

package.nls.json

Please only make necessary changes to reduce the size of of the PR. In this file, the only change is the inserted line of:

"contributes.commands.java.view.triggerJavaUpgradeTool": "Upgrade dependencies",

Formatting are restored in c2c4cf6.

akaroml · 2025-09-10T03:39:40Z

src/constants.ts

+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE = "java-engine";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_ENGINE = "Java Engine";
+    export const PROMOTION_DIAGNOSTIC_SOURCE = "Java";
+    export const EARLIEST_JAVA_VERSION_NOT_TO_PROMPT = 21;


LATEST_JAVA_LTS_VERSION

Done in 56084e6.

akaroml · 2025-09-10T03:40:16Z

src/constants.ts

@@ -35,6 +35,13 @@ export namespace ExtensionName {
    export const JAVA_LANGUAGE_SUPPORT: string = "redhat.java";
 }

+export namespace Upgrade {
+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE = "java-engine";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_ENGINE = "Java Engine";


Use "java-upgrade-assistant" and "Java Upgrade Assistant" instead.

Changed to java:* to align with the java-upgrade extension.

akaroml · 2025-09-10T03:40:59Z

src/constants.ts

+export namespace Upgrade {
+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_ENGINE = "java-engine";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_ENGINE = "Java Engine";
+    export const PROMOTION_DIAGNOSTIC_SOURCE = "Java";


"Java Upgrade Assistant"

akaroml · 2025-09-10T03:42:00Z

src/extension.ts

@@ -2,8 +2,10 @@
 // Licensed under the MIT license.

 import * as path from "path";
-import { commands, Diagnostic, Extension, ExtensionContext, extensions, languages,
-    Range, tasks, TextDocument, TextEditor, Uri, window, workspace } from "vscode";
+import {


Please avoid unnecessary changes.

Fixed in c3ee610.

akaroml · 2025-09-10T03:42:25Z

src/syncHandler.ts

@@ -26,7 +27,7 @@ class SyncHandler implements Disposable {
        if (autoRefresh) {
            instrumentOperation(ENABLE_AUTO_REFRESH, () => this.enableAutoRefresh())();
        } else {
-            instrumentOperation(DISABLE_AUTO_REFRESH, () => {})();
+            instrumentOperation(DISABLE_AUTO_REFRESH, () => { })();


Avoid unnecessary changes.

akaroml · 2025-09-10T03:42:35Z

src/syncHandler.ts

@@ -122,7 +124,7 @@ class SyncHandler implements Disposable {
        } else {
            // in flat view
            if (path.extname(uri.fsPath) === ".java" && node.uri &&
-                    Uri.parse(node.uri).fsPath === path.dirname(uri.fsPath)) {


Avoid unnecessary changes.

akaroml · 2025-09-10T03:56:31Z

src/upgrade/upgradeManager.ts

+        );
+    }
+
+    private async checkUpgradableComponents(folder: WorkspaceFolder) {


Since we are already in Project Explorer, we already know all the dependencies and the version of java runtimes. Can we work with the project metadata directly? wihtout parsing the POM/Gradle files manually? CC @jdneo

akaroml

In general, I wasn't expecting so many code changes. The fat implementation of manually parsing everything is the root cause. As commented, please consider work with the project metadata directly. In the metadata, the runtime version and dependency versions should all be available.

akaroml

In general, I wasn't expecting so many code changes. The fat implementation of manually parsing everything is the root cause. As commented, please consider work with the project metadata directly. In the metadata, the runtime version and dependency versions should all be available.

FluoriteCafe-work · 2025-09-10T06:34:01Z

@akaroml Thanks for the review!

As commented, please consider work with the project metadata directly. In the metadata, the runtime version and dependency versions should all be available.

The code is now working with Jdtls to retrieve all metadata. The extension has already gone through the process once, but it's in a lazy-loading way - only retrieving needed parts (projects and dependencies etc.) when user expands the nodes in tree view. As a result, the PR need to actively call Jdtls by itself to gain a full picture.

wangmingliang-ms · 2025-09-12T02:20:19Z

src/constants.ts

+export namespace Upgrade {
+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_RUNTIME = "java-upgrade-assistant";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_RUNTIME = "Java Upgrade Assistant";
+    export const LATEST_JAVA_LTS_VESRION = 21;


why is only Java here, where is SpringBoot...? is this used outside metadataManager?

Java related metadata are now moved into dependency.data.ts.

wangmingliang-ms · 2025-09-12T02:22:14Z

package.json

@@ -288,6 +288,16 @@
        "command": "java.view.package.renameFile",
        "title": "%contributes.commands.java.view.package.renameFile%",
        "category": "Java"
+      },
+      {
+        "command": "java.view.triggerJavaUpgradeTool",


how about "xxx.upgradeRuntimeAndFrameworks" or "xxx.upgradeWithCopilot"

Fixed in 81b9905 & 28d2ee4

wangmingliang-ms · 2025-09-12T02:28:02Z

src/settings.ts

@@ -108,6 +108,10 @@ export class Settings {
        return workspace.getConfiguration("java.dependency").get("refreshDelay", 2000);
    }

+    public static getShowUpgradeReminder() {


isDependencyDiagnosingEnabled()?

Changed to Settings.getEnableDependencyDiagnostics() - cabb469

wangmingliang-ms · 2025-09-12T02:31:22Z

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/model/PackageNode.java

+            IFile existingPom = proj.getFile("pom.xml");
+            if (existingPom.exists()) {
+                projectNode.setMetaDataValue(POM_PATH, existingPom.getLocation().toOSString());
+            }


is this still needed? we don't need to show diagnostics according to the adjusted scope.

Nope for now. I'll remove parts related to POM path parsing.

Removed in 2789537

wangmingliang-ms · 2025-09-12T02:32:48Z

src/upgrade/display/notificationManager.ts

+    private isCandidate() {
+        return this.context?.globalState.get<boolean>(IS_CANDIDATE_KEY, true);
+    }
+
+    private setCandidate(isCandidate: boolean) {
+        this.context?.globalState.update(IS_CANDIDATE_KEY, isCandidate);
+    }


I realized it should actually be changed to read from/write to the setting item java.dependency.enableDependencyDiagnosing. Will change later.

The button should change to workspace-level setting rather than user-level setting.

Fixed by 1f0a36f

wangmingliang-ms · 2025-09-12T02:35:08Z

src/constants.ts

+    export const DIAGNOSTICS_GROUP_ID_FOR_JAVA_RUNTIME = "java-upgrade-assistant";
+    export const DIAGNOSTICS_NAME_FOR_JAVA_RUNTIME = "Java Upgrade Assistant";
+    export const LATEST_JAVA_LTS_VESRION = 21;
+    export const SESSION_COUNT_BEFORE_NOTIFICATION_RESHOW = 3;


is this also used outside the notificationManager?

Moved most strings in their own files - 56084e6.

src/upgrade/dependency.data.ts

src/upgrade/upgradeManager.ts

src/upgrade/display/notificationManager.ts

wangmingliang-ms · 2025-09-12T06:09:59Z

src/constants.ts

+}
+
+export namespace Upgrade {
+    export const PACKAGE_ID_FOR_JAVA_RUNTIME = "java-runtime:*";


Fixed in 76a8261.

wangmingliang-ms · 2025-09-12T06:17:51Z

src/upgrade/upgradeManager.ts

+
+const DEFAULT_UPGRADE_PROMPT = "Upgrade Java project dependency to latest version.";
+
+function getJavaIssues(data: INodeData): UpgradeIssue[] {


telemeter detected upgrade issues.

dependency name
current version

Fixed in e25d0b6 & 46f78a8.

wangmingliang-ms · 2025-09-12T06:20:00Z

src/upgrade/display/notificationManager.ts

+            notificationMessage,
+            BUTTON_TEXT_UPGRADE,
+            BUTTON_TEXT_NOT_NOW,
+            BUTTON_TEXT_DONT_SHOW_AGAIN);


telemeter user actions.

Fixed in e25d0b6.

….dependency.enableDependencyDiagnostics`

…roject`

…grade`

…_NOTIFICATION_RESHOW` to individual files

…ification

wangmingliang-ms reviewed Sep 3, 2025

View reviewed changes

FluoriteCafe-work changed the title ~~Promote Java Upgrade Tool on projects using old (<21) Java~~ Promote Java Upgrade Tool on projects using old (<21) Java and EOL Spring Sep 3, 2025

FluoriteCafe-work force-pushed the feat/java-upgrade-tool-notification branch from 67e3caa to 6adb53b Compare September 4, 2025 06:34

FluoriteCafe-work changed the title ~~Promote Java Upgrade Tool on projects using old (<21) Java and EOL Spring~~ Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions Sep 8, 2025

FluoriteCafe-work force-pushed the feat/java-upgrade-tool-notification branch 2 times, most recently from 6cd7dd9 to 991c776 Compare September 8, 2025 06:30

This comment was marked as outdated.

Sign in to view

akaroml reviewed Sep 10, 2025

View reviewed changes

akaroml requested a review from jdneo September 10, 2025 03:59

akaroml requested changes Sep 10, 2025

View reviewed changes

FluoriteCafe-work added 9 commits September 10, 2025 12:35

feat(jdtls): add PomPath to metadata

3872005

feat: MetadataManager

5574787

feat: add command triggerJavaUpgradeTool

3988de5

feat: NotificationManager

bf7eb04

feat: IssueManager

18be55e

feat(upgradeManager): collect issues on load and workspace folder update

560048c

feat: integrate the flow

0503046

feat: add context menu to open modernization tool

b2406d9

fix: only show modernization menu when related extension is installed

fa488ef

FluoriteCafe-work force-pushed the feat/java-upgrade-tool-notification branch from abfd8c7 to fa488ef Compare September 10, 2025 06:23

FluoriteCafe-work added 2 commits September 10, 2025 14:26

fix: typo

9fbc1c2

chore: fmt

c3ee610

FluoriteCafe-work added 4 commits September 10, 2025 14:50

feat: control reminder display by settings

0e998ba

feat: don't scan when upgrade extension does not exist

3b62771

chore: make class methods static as there are no states here

9043db4

fix: typo

06c14d9

wangmingliang-ms reviewed Sep 12, 2025

View reviewed changes

chore: centralize JRE metadata together

6655cd8

FluoriteCafe-work commented Sep 12, 2025

View reviewed changes

src/upgrade/dependency.data.ts Show resolved Hide resolved

FluoriteCafe-work commented Sep 12, 2025

View reviewed changes

src/upgrade/upgradeManager.ts Outdated Show resolved Hide resolved

FluoriteCafe-work commented Sep 12, 2025

View reviewed changes

src/upgrade/display/notificationManager.ts Outdated Show resolved Hide resolved

wangmingliang-ms reviewed Sep 12, 2025

View reviewed changes

FluoriteCafe-work added 17 commits September 12, 2025 15:01

chore: rename settings java.dependency.showUpgradeReminder -> `java…

cabb469

….dependency.enableDependencyDiagnostics`

fix: only show Modernize Java Project under Java project environment

7c606cb

chore: java.view.modernizeJavaProject -> `_java.view.modernizeJavaP…

4bdc6d6

…roject`

chore: java.view.triggerJavaUpgradeTool -> `_java.upgrade.triggerUp…

81b9905

…grade`

chore: change JRE package ID to java:*

76a8261

chore: centralize LATEST_JAVA_LTS_VESRION and `SESSION_COUNT_BEFORE…

56084e6

…_NOTIFICATION_RESHOW` to individual files

chore: _java.upgrade.triggerUpgrade -> _java.upgradeWithCopilot

28d2ee4

chore: no need for PomPath

2789537

fix(notificationManager): use settings to control whether to send not…

1f0a36f

…ification

chore: split assessment part to assessmentManager

fbe2d5f

feat: use DisplayInterface to organize user faced presentations

790a5ea

chore: string improvements

1872705

chore: get all issues for notification

e9b6917

feat: add telemetry

e25d0b6

fix: add current version to telemetry

46f78a8

chore: restore formatting

c2c4cf6

fix: pass suggestedVersion to UpgradeIssue

1c1fef6


		const DEFAULT_UPGRADE_PROMPT = "Upgrade Java project dependency to latest version.";

		function getJavaIssues(data: INodeData): UpgradeIssue[] {

Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions #901

Are you sure you want to change the base?

Remind users to upgrade old (<21) Java and EOL Spring Boot/Framework versions #901

Uh oh!

Conversation

FluoriteCafe-work commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FluoriteCafe-work commented Sep 3, 2025

Uh oh!

wangmingliang-ms Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FluoriteCafe-work Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

akaroml left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akaroml left a comment

Choose a reason for hiding this comment

Uh oh!

akaroml left a comment

Choose a reason for hiding this comment

Uh oh!

FluoriteCafe-work commented Sep 10, 2025

Uh oh!

wangmingliang-ms Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangmingliang-ms Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FluoriteCafe-work commented Sep 3, 2025 •

edited

Loading

wangmingliang-ms Sep 3, 2025 •

edited

Loading

FluoriteCafe-work Sep 3, 2025 •

edited

Loading

wangmingliang-ms Sep 12, 2025 •

edited

Loading

wangmingliang-ms Sep 12, 2025 •

edited

Loading

FluoriteCafe-work Sep 12, 2025 •

edited

Loading

wangmingliang-ms Sep 12, 2025 •

edited

Loading

FluoriteCafe-work Sep 12, 2025 •

edited

Loading