chore: replace hostName with fqdnOrHostName #421
Conversation
There was a problem hiding this comment.
Modules that accept a mere networking.hostName but prefer a fully qualified domain name may use networking.fqdnOrHostName instead.
https://search.nixos.org/options?channel=unstable&show=networking.fqdn&query=networking.fqdn
|
I haven't had the time to test yet, will do in the next days... |
Ok works. Now this change works without breaking changes if If I am correct, systems that have a domain set will still encounter breaking changes, right? How should we proceed? |
felbinger
changed the title
|
@astro how do we could handle this? |
|
Also the CI tests are failing for some reason I did not grasp yet. |
| before = [ | ||
| "microvm@${name}.service" | ||
| "microvm-tap-interfaces@${name}.service" | ||
| "microvm-tap-interfaces@${name}.service" # TODO split after first . |
There was a problem hiding this comment.
Splitting will lead to conflicts between vm.example.com and vm.example.org which I assumed this PR was going to solve. I guess we should rather escape here.
3 participants
Using fully qualified domain names as unique identifier for containers improves identification of containers on large (potentially multi tenant) hypervisors.
In the current version using a container name containing a dot doesn't work. I forked microvm.nix and adjusted it so that fqdn's are used by default.
Should we try to upstream this? If yes how?
I drafted this change because merging this would result in breaking changes if
networking.domainis being set for a machine.