Skip to content

enhance: [2.5]Make GeometryCache an optional configuration #45197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sre-ci-robot merged 2 commits into from
Nov 3, 2025
Merged

enhance: [2.5]Make GeometryCache an optional configuration #45197

sre-ci-robot merged 2 commits into from
Nov 3, 2025

Conversation

@xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Oct 31, 2025

issue: #45187
master pr: #45192

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 31, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 31, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Oct 31, 2025

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Oct 31, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Oct 31, 2025

[INFO] PR Label Summary by Default
[FAILED] PR #45192 not merged

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@xiaocai2333 xiaocai2333 added this to the 2.5.20 milestone Oct 31, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2025

@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 31, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.17647% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.05%. Comparing base (3a7a08f) to head (4e42273).
⚠️ Report is 37 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/segcore/SegmentGrowingImpl.cpp 33.33% 4 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 33.33% 4 Missing ⚠️
internal/core/src/segcore/segcore_init_c.cpp 0.00% 4 Missing ⚠️
...core/src/exec/expression/GISFunctionFilterExpr.cpp 87.50% 3 Missing ⚠️
internal/querynodev2/server.go 25.00% 2 Missing and 1 partial ⚠️
internal/core/src/common/GeometryCache.h 71.42% 2 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 2 Missing ⚠️
internal/core/src/segcore/SegcoreConfig.h 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #45197      +/-   ##
==========================================
- Coverage   82.10%   82.05%   -0.06%     
==========================================
  Files        1128     1588     +460     
  Lines      179181   248672   +69491     
==========================================
+ Hits       147110   204036   +56926     
- Misses      26099    38625   +12526     
- Partials     5972     6011      +39
Components Coverage Δ
Client 78.90% <22.22%> (-0.06%) ⬇️
Core 84.53% <69.67%> (∅)
Go 82.37% <77.63%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/util/initcore/init_core.go 88.41% <100.00%> (+0.20%) ⬆️
pkg/util/paramtable/component_param.go 98.72% <100.00%> (+<0.01%) ⬆️
internal/core/src/segcore/SegcoreConfig.h 89.47% <50.00%> (ø)
internal/core/src/common/GeometryCache.h 31.37% <71.42%> (ø)
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 21.33% <0.00%> (ø)
...core/src/exec/expression/GISFunctionFilterExpr.cpp 68.11% <87.50%> (ø)
internal/querynodev2/server.go 65.65% <25.00%> (-0.36%) ⬇️
internal/core/src/segcore/SegmentGrowingImpl.cpp 73.80% <33.33%> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 78.06% <33.33%> (ø)
internal/core/src/segcore/segcore_init_c.cpp 20.43% <0.00%> (ø)

... and 499 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

czs007
czs007 reviewed Oct 31, 2025
View reviewed changes
pkg/util/paramtable/component_param.go Outdated

p.EnableGeometryCache = ParamItem{
Key: "queryNode.segcore.enableGeometryCache",
Version: "2.6.5",
Copy link
Collaborator

@czs007 czs007 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong version

@xiaocai2333
fix wrong version
4e42273 
Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Oct 31, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Oct 31, 2025

[INFO] PR Label Summary by Default
[FAILED] PR #45192 not merged

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2025

@xiaocai2333 cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

czs007
czs007 approved these changes Nov 2, 2025
View reviewed changes
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 2, 2025

[INFO] PR Label Summary by Default
[FAILED] PR #45192 not merged

Use /refresh-label to update related check and label manually

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Nov 3, 2025

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Nov 3, 2025

/ci-rerun-ut-go

1 similar comment
@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Nov 3, 2025

/ci-rerun-ut-go

@mergify mergify bot added the ci-passed label Nov 3, 2025
@xiaocai2333
Copy link
Contributor Author

xiaocai2333 commented Nov 3, 2025

/refresh-label

@sre-ci-robot sre-ci-robot removed the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Nov 3, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 3, 2025

[INFO] PR Label Summary by Refresh-Label

  • Title: enhance: [2.5]Make GeometryCache an optional configuration
  • Target: 2.5
  • Labels: kind/enhancement, size/L, approved, lgtm, ci-passed, dco-passed, do-not-merge/need-merge-master-first

[SUCCESS] PR #45192 merged to master

Use /refresh-label to update related check and label manually

@sre-ci-robot sre-ci-robot merged commit cc9735f into milvus-io:2.5 Nov 3, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 czs007 approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

Assignees

@czs007 czs007

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

2.5.20

Development

Successfully merging this pull request may close these issues.

3 participants

@xiaocai2333 @sre-ci-robot @czs007