[minify-backend用] フィジビリティ検証 #16878

samunohito · 2025-11-27T14:41:25Z

What

#16852 向け。developではなくminify-backendブランチに向けています。
backendのminifyが可能かどうかを検証　→node_modulesは含んでいないが、バックエンド単体のminifyそのものは出来た

Why

Additional info (optional)

Checklist

Read the contribution guide
Test working in a local environment
(If needed) Add story of storybook
(If needed) Update CHANGELOG.md
(If possible) Add tests

samunohito · 2025-11-27T14:43:23Z

package.json

-		"start": "cd packages/backend && node ./built/entry.js",
-		"start:inspect": "cd packages/backend && node --inspect ./built/entry.js",
-		"start:test": "ncp ./.github/misskey/test.yml ./.config/test.yml && cd packages/backend && cross-env NODE_ENV=test node ./built/entry.js",
+		"start": "cd packages/backend && node ./built/boot/entry.js",


バックエンドのビルド成果物に依存しているcheck_connect.jsが動かないので、代替手段を考える必要がある

samunohito · 2025-11-27T14:44:07Z

packages/backend/build.js

+const resolveTsPathsPlugin = {
+	name: 'resolve-ts-paths',
+	setup(build) {
+		build.onResolve({ filter: /^\.{1,2}\/.*\.js$/ }, (args) => {
+			if (args.importer) {
+				const absPath = join(args.resolveDir, args.path);
+				const tsPath = absPath.slice(0, -3) + '.ts';
+				if (fs.existsSync(tsPath)) {
+					return { path: tsPath };
+				}
+			}
+		});
+	},
+};


拡張子.jsを愚直にimportしようとするため、tsに置き換えておかないとfile not foundになる

samunohito · 2025-11-27T14:44:31Z

packages/backend/build.js

+const externalIpaddrPlugin = {
+	name: 'external-ipaddr',
+	setup(build) {
+		build.onResolve({ filter: /^ipaddr\.js$/ }, (args) => {
+			return { path: args.path, external: true };
+		});
+	},
+};


esbuildがipaddr.jsを外部パッケージだと認識しないので

samunohito · 2025-11-27T14:45:01Z

packages/backend/build.js

-	//minify: process.env.NODE_ENV === 'production',
-	minify: false,
+	minify: true,
+	keepNames: true,


これが無いとNestJSのDIが破綻する

samunohito · 2025-11-27T14:45:26Z

packages/backend/build.js

 	format: 'esm',
-	sourcemap: false,
+	sourcemap: 'linked',
+	packages: 'external',


とりあえずnode_modulesは除外中

samunohito · 2025-11-27T14:46:05Z

packages/backend/build.js

+		swcPlugin({
+			jsc: {
+				parser: {
+					syntax: 'typescript',
+					decorators: true,
+					dynamicImport: true,
+				},
+				transform: {
+					legacyDecorator: true,
+					decoratorMetadata: true,
+				},
+				experimental: {
+					keepImportAssertions: true,
+				},
+				baseUrl: join(_dirname, 'src'),
+				paths: {
+					'@/*': ['*'],
+				},
+				target: 'esnext',
+				keepClassNames: true,
+			},
+		}),


esbuild単体だとレガシーデコレーターの解釈が出来ずバックエンドの起動に失敗するため、SWCの力を借りる必要があった

samunohito · 2025-11-27T14:47:20Z

packages/backend/build.js

+	const rootDir = resolve(_dirname, '../..');
+	await Promise.all([
+		copyBackendViews(rootDir),
+		buildBackendScript(rootDir, buildLocales()),
+		buildBackendStyle(rootDir),
+	]);


build-assetsでコピーされるファイル群。
パスの解決やLANGSの置き換えなど、結構厳しい部分が残っているのでこれを機に整理するのが良さそう

samunohito · 2025-11-27T14:48:49Z

packages/backend/src/config.ts

- */
-const dir = `${_dirname}/../../../.config`;
+/** Path of repository root directory */
+const rootDir = resolve(_dirname, '../../../../');


ビルド後のファイルからの相対パス

samunohito · 2025-11-27T14:49:39Z

scripts/build-assets-func.mjs

バックエンドから無理くり引き回すため切り離したファイル。
前述したが、静的ファイルのコピーなどは改めて見直した方が良さそう

syuilo · 2025-11-30T05:44:01Z

これブランチ追従してもらうことできるかしら

samunohito · 2025-11-30T05:46:15Z

いちおう現時点までの最新まで追従しますが、 #16889 も入れないと完全にはならなさそうです

syuilo · 2025-11-30T05:47:00Z

バンドルなしでnode_modulesのminifyは #16904 で一応可能ということが分かったのでひとまずバックエンド単体のminifyで十分かもしれない

# Conflicts: # packages/backend/package.json # pnpm-lock.yaml # scripts/build-assets.mjs

samunohito · 2025-11-30T05:58:42Z

🎉 と思ったけど、結局相対パス絡みでbuild-assets.mjsまわりの改修が入るのでやっぱり enhance(backend): pugをやめ、JSXベースのテンプレートに変更 (to misskey-dev dev branch) #16889 が欲しいかもしれない
ちょっと所用で1時間ばかり作業不可になるので追従が送れるかもしれない

codecov · 2025-11-30T08:23:13Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (minify-backend@e44f993). Learn more about missing BASE report.

Additional details and impacted files

@@                Coverage Diff                @@
##             minify-backend   #16878   +/-   ##
=================================================
  Coverage                  ?   14.00%           
=================================================
  Files                     ?      237           
  Lines                     ?    11287           
  Branches                  ?     3733           
=================================================
  Hits                      ?     1581           
  Misses                    ?     7584           
  Partials                  ?     2122

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

samunohito · 2025-11-30T08:28:08Z

@syuilo
追従はしました（がテストがいっぱいしんでる）

syuilo · 2025-12-03T03:03:13Z

#16889 は入った

syuilo · 2025-12-03T03:04:22Z

時間のあるとき再度ブランチ追従してもらえると助かる

syuilo · 2025-12-24T03:53:10Z

引き継ごうかしら

samunohito · 2025-12-24T03:54:07Z

（返信あったの気づいてなかった）

samunohito · 2025-12-24T03:54:36Z

あとでやっておきますわ

# Conflicts: # package.json # packages/backend/package.json # packages/backend/src/config.ts # pnpm-lock.yaml # scripts/build-assets.mjs

samunohito · 2025-12-24T11:55:04Z

やっておきましたわ

syuilo · 2025-12-24T11:55:25Z

🙏

samunohito · 2025-12-24T11:56:27Z

最新のdevelopを直接取り込んでおります

syuilo · 2025-12-31T05:08:49Z

すごい、30MB減った

Before

After

どちらも強制GC済み

syuilo · 2025-12-31T05:12:06Z

Before

After

samunohito · 2025-12-31T05:15:20Z

向き先はdevelopではなくminify-backendなので、よさそうであればそのまま持って行っちゃってください

syuilo · 2025-12-31T05:18:07Z

🙏🏻

syuilo · 2025-12-31T05:23:42Z

若干だけど起動も速くなったような気がしないでもない

* wip * Update build.js * Update build.js * [minify-backend用] フィジビリティ検証 (#16878) * fix: minify-backend * 間違えて入れちゃったのを戻す * 追従 * fix --------- Co-authored-by: syuilo <[email protected]> * test * use node 24 * Revert "use node 24" This reverts commit 7ae2deb. * Revert "test" This reverts commit d919879. * Update package.json * wip * Update compile_config.js * Revert "Update compile_config.js" This reverts commit 0ee286f. * Update config.ts * wip * Update .swcrc * Update ClientServerService.ts * [ci skip] update CHANGELOG --------- Co-authored-by: おさむのひと <[email protected]>

fix: minify-backend

52c02ee

github-project-automation bot added this to [実験中] 管理用 Nov 27, 2025

github-project-automation bot moved this to Todo in [実験中] 管理用 Nov 27, 2025

github-actions bot added the packages/backend Server side specific issue/PR label Nov 27, 2025

samunohito mentioned this pull request Nov 27, 2025

バックエンドのコードもbundle+minifyする #16852

Open

1 task

間違えて入れちゃったのを戻す

5be084e

samunohito commented Nov 27, 2025

View reviewed changes

samunohito mentioned this pull request Nov 28, 2025

ビルドプロセスとディレクトリ構造の改善提案 (locales & backend) #16879

Closed

Merge branch 'minify-backend' into minify-backend-ex

db661c2

# Conflicts: # packages/backend/package.json # pnpm-lock.yaml # scripts/build-assets.mjs

追従

b901c10

samunohito added 2 commits December 24, 2025 20:02

Merge branch 'develop' into minify-backend-ex

7557707

# Conflicts: # package.json # packages/backend/package.json # packages/backend/src/config.ts # pnpm-lock.yaml # scripts/build-assets.mjs

fix

dfb4904

github-actions bot added packages/frontend Client side specific issue/PR packages/misskey-js packages/backend:test packages/sw labels Dec 24, 2025

syuilo added 3 commits December 28, 2025 20:56

Merge branch 'minify-backend' into minify-backend-ex

1b19031

Merge branch 'develop' into pr/16878

87674cc

Merge branch 'minify-backend' into pr/16878

0f6fb75

syuilo marked this pull request as ready for review December 31, 2025 05:13

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 31, 2025

syuilo merged commit 8bba886 into misskey-dev:minify-backend Dec 31, 2025
21 of 29 checks passed

github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Dec 31, 2025

Uh oh!

[minify-backend用] フィジビリティ検証 #16878

[minify-backend用] フィジビリティ検証 #16878

Uh oh!

Conversation

samunohito commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Additional info (optional)

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syuilo commented Nov 30, 2025

Uh oh!

samunohito commented Nov 30, 2025

Uh oh!

syuilo commented Nov 30, 2025

Uh oh!

samunohito commented Nov 30, 2025

Uh oh!

codecov bot commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samunohito commented Nov 30, 2025

Uh oh!

syuilo commented Dec 3, 2025

Uh oh!

syuilo commented Dec 3, 2025

Uh oh!

syuilo commented Dec 24, 2025

Uh oh!

samunohito commented Dec 24, 2025

Uh oh!

samunohito commented Dec 24, 2025

Uh oh!

samunohito commented Dec 24, 2025

Uh oh!

syuilo commented Dec 24, 2025

Uh oh!

samunohito commented Dec 24, 2025

Uh oh!

syuilo commented Dec 31, 2025

Uh oh!

syuilo commented Dec 31, 2025

Before

After

Uh oh!

samunohito commented Dec 31, 2025

Uh oh!

Uh oh!

syuilo commented Dec 31, 2025

Uh oh!

syuilo commented Dec 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

samunohito commented Nov 27, 2025 •

edited

Loading

codecov bot commented Nov 30, 2025 •

edited

Loading