Skip to content

Conversation

@anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Dec 13, 2025

What

TRANSIENTスコープの @Injectable を使用することで、Channelの依存となる service をバケツリレーしないでいいように、つまり今後のChannelの拡張を容易にしました。

#16983 をやってる最中に少し思ったのでやってみました。

ある程度の動作確認はローカルで実行しました

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 13, 2025
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 13, 2025
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

❌ Patch coverage is 74.81108% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.80%. Comparing base (e0b872d) to head (a808e2d).
⚠️ Report is 42 commits behind head on develop.

Files with missing lines Patch % Lines
...ckages/backend/src/server/api/stream/Connection.ts 40.00% 45 Missing ⚠️
...s/backend/src/server/api/stream/ChannelsService.ts 0.00% 38 Missing ⚠️
...ges/backend/src/core/activitypub/ApInboxService.ts 0.00% 7 Missing ⚠️
...ackend/src/server/api/StreamingApiServerService.ts 40.00% 6 Missing ⚠️
...end/src/core/activitypub/models/ApPersonService.ts 75.00% 1 Missing ⚠️
...d/src/core/activitypub/models/ApQuestionService.ts 50.00% 1 Missing ⚠️
...ackages/backend/src/server/api/endpoints/ap/get.ts 0.00% 1 Missing ⚠️
...ckages/backend/src/server/api/endpoints/ap/show.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #16985      +/-   ##
===========================================
- Coverage    62.83%   62.80%   -0.04%     
===========================================
  Files         1150     1150              
  Lines       115228   114912     -316     
  Branches      7892     7870      -22     
===========================================
- Hits         72400    72165     -235     
+ Misses       40668    40604      -64     
+ Partials      2160     2143      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2025

Backend Memory Usage Comparison

Metric base head Diff
RSS 353.73 MB 359.80 MB 6.06 MB (1.71%)

See workflow logs for details

@anatawa12
Copy link
Member Author

同様のことが apResolver 周りでもできるはずです

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 13, 2025
@anatawa12
Copy link
Member Author

apResolverのほうも ready

@syuilo syuilo merged commit 74e847a into misskey-dev:develop Dec 22, 2025
39 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 22, 2025

👍

@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Dec 22, 2025
@anatawa12 anatawa12 deleted the request-scope-di branch January 6, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants