-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: use TRANSIENT scope to avoid service bucket relay #16985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #16985 +/- ##
===========================================
- Coverage 62.83% 62.80% -0.04%
===========================================
Files 1150 1150
Lines 115228 114912 -316
Branches 7892 7870 -22
===========================================
- Hits 72400 72165 -235
+ Misses 40668 40604 -64
+ Partials 2160 2143 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
このPRによるapi.jsonの差分 |
Backend Memory Usage Comparison
|
|
同様のことが apResolver 周りでもできるはずです |
0b1b084 to
a808e2d
Compare
|
apResolverのほうも ready |
|
👍 |
What
TRANSIENTスコープの
@Injectableを使用することで、Channelの依存となる service をバケツリレーしないでいいように、つまり今後のChannelの拡張を容易にしました。#16983 をやってる最中に少し思ったのでやってみました。
ある程度の動作確認はローカルで実行しました
Why
Additional info (optional)
Checklist